Repository navigation
feat(connections): give each database in the connections strip its own tabs - #3436
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With many databases or tenant schemas on one connection, every database's tabs piled into one tab strip, and same-named tables were easy to mix up. The connections strip already lists each database as an entry, but only a connection switch swapped the tabs. A database switch from the toolbar or sidebar left the previous database's tab on screen.
Change
switch_databaseandswitch_schemaincluded, lands on that database's last tab. Picking a tab of another database moves the sidebar there without changing the saved default.open_table_tabmatching. Dropped databases leave the strip.Verified
QueryTabManagerVisibleContainerTestsandVisibleContainerFollowingTestsare new. Changed on purpose:SwitchDatabaseTests,WorkspaceAnchoringTests,WorkspaceRailStoreTestsandCommandActionsBulkCloseTests(empty tabs now list their entry),QueryTabManagerRecencyTests(deferral removed). Checked against MariaDB with two tenants.Screenshots
Not in this PR
Fixes #3431