Skip to content

fix(linux): address the review findings on steps 40 to 45 - #3416

Merged
datlechin merged 7 commits into
linuxfrom
fix/linux-group2-review
Oct 14, 2026
Merged

datlechin merged 7 commits into
linuxfrom
fix/linux-group2-review

Conversation

@datlechin

Copy link
Copy Markdown
Member

Why

The Codex and security reviews of #3413 found seven defects in Steps 40 to 45.

Change

  • Query history withholds a credential function called in a join or WHERE condition, MySQL CLONE ... IDENTIFIED BY, and encryption calls that take a key (MySQL AES and DES, pgcrypto, ClickHouse).
  • Replace Key and Connect only removes a key for the session's own hosts and known_hosts files, as ssh -G resolves them; a trusted key matches host and fingerprint together.
  • Opening a file only matches a saved file connection whose database is an absolute path, never a network connection.
  • A SQLite rebuild refuses a new foreign key violation even when the row broke the old key; a cell menu acts only on the rows it opened for; a launch during the quit's last write restores the sessions.

Verified

Each fix has a test that fails without it; fmt, both clippy runs, nextest and cargo test suites pass in the ubuntu:26.04 image.

Not in this PR

  • Replace is refused for a UserKnownHostsFile path with a space, which ssh -G prints unquoted.

@datlechin
datlechin merged commit 52e6661 into linux Oct 14, 2026
13 checks passed
@datlechin
datlechin deleted the fix/linux-group2-review branch October 14, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant