Repository navigation
fix(linux): address the review findings on steps 40 to 45 - #3416
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Codex and security reviews of #3413 found seven defects in Steps 40 to 45.
Change
CLONE ... IDENTIFIED BY, and encryption calls that take a key (MySQL AES and DES, pgcrypto, ClickHouse).ssh -Gresolves them; a trusted key matches host and fingerprint together.Verified
Each fix has a test that fails without it; fmt, both clippy runs, nextest and
cargo testsuites pass in theubuntu:26.04image.Not in this PR
UserKnownHostsFilepath with a space, whichssh -Gprints unquoted.