refactor(linux): finish remediation steps 40 to 45

.github/workflows/build-linux.yml

@@ -106,21 +106,41 @@ jobs:
             echo "::error::crates/app/src/services must not hold thread_local! state"
             exit 1
           fi
-      - name: No blocking file I/O in the window and editor code
+      - name: No blocking file I/O in the UI code
         # This code runs on the GTK thread, where a slow disk or a
         # network mount freezes the window. A storage call ending in
         # _blocking is handed to spawn_blocking_task on the same line,
-        # which is what this check can see. Tests may do either.
+        # which is what this check can see. A Path method that stats the
+        # disk blocks the same way. Tests may do either.
         run: |
           # The $0 in the awk program is awk's record, not a shell variable.
           # shellcheck disable=SC2016
-          found=$(find crates/app/src/ui/app crates/app/src/ui/editor -name '*.rs' ! -name tests.rs -print0 \
-            | xargs -0 awk '/^mod tests \{/ { nextfile } /std::fs::/ || (/_blocking\(/ && !/spawn_blocking_task\(/) { print FILENAME ":" FNR ": " $0 }')
+          found=$(find crates/app/src/ui -name '*.rs' ! -name tests.rs -print0 \
+            | xargs -0 awk '/^mod tests \{/ { nextfile } /std::fs::/ || /\.(exists|try_exists|is_dir|is_file|is_symlink|canonicalize|read_dir|read_link|symlink_metadata)\(/ || (/_blocking\(/ && !/spawn_blocking_task\(/) { print FILENAME ":" FNR ": " $0 }')
           if [ -n "$found" ]; then
             echo "$found"
-            echo "::error::crates/app/src/ui/app and crates/app/src/ui/editor must not call std::fs, or a _blocking function outside spawn_blocking_task"
+            echo "::error::crates/app/src/ui must not call std::fs or a Path method that reads the disk, or a _blocking function outside spawn_blocking_task"
             exit 1
           fi
+      - name: Window actions on the window's own map
+        # GTK exports a window's own action map as win. A group inserted
+        # under that name hides it from the application's accelerators
+        # and from D-Bus.
+        run: |
+          if grep -rn 'insert_action_group("win"' crates/app/src; then
+            echo "::error::add window actions with add_action_entries on the window, not a group inserted as win"
+            exit 1
+          fi
+      - name: Docs name paths and types that exist
+        # A renamed type or a moved file stays named in prose until
+        # something asks. GTK and GLib names resolve against the GIR
+        # files the -dev packages install.
+        run: |
+          ../scripts/check-doc-symbols.sh \
+            linux/ARCHITECTURE.md \
+            linux/docs/state-management.md \
+            linux/docs/testing.md \
+            linux/docs/decisions/0012-window-per-session.md
       - name: Clippy
         run: meson devenv -C _build cargo clippy --locked --workspace --all-targets -- -D warnings
       - name: Clippy without default features

linux/AGENTS.md

@@ -1,6 +1,6 @@
 # TablePro for Linux
 
-The native Linux app: Rust, GTK 4 and libadwaita through Relm4, built with Meson and Cargo. The platform floor is GNOME 50 (GTK 4.22, libadwaita 1.9, GtkSourceView 5.18, GLib 2.88). It shares no code with the macOS app.
+The native Linux app: Rust, GTK 4 and libadwaita through gtk-rs, built with Meson and Cargo. The platform floor is GNOME 50 (GTK 4.22, libadwaita 1.9, GtkSourceView 5.18, GLib 2.88). It shares no code with the macOS app.
 
 This is the guide for work under `linux/`. The root `AGENTS.md` describes the macOS and iOS apps; of it, only the principles named below, "Writing style" and the commit rules apply here. Claude Code loads this file through `linux/CLAUDE.md` once a file under `linux/` is read; Codex reads it when started in `linux/`, so otherwise read it yourself.
 
@@ -18,7 +18,7 @@ This is the guide for work under `linux/`. The root `AGENTS.md` describes the ma
 
 ## Map
 
-- `crates/app`: the binary and every Relm4 component. `crates/core`: domain types and traits, no GUI. `crates/storage`: secrets, settings and files. `crates/session`, `crates/net`, `crates/ssh`: sessions, the network layer and the OpenSSH transport. `crates/drivers/*`: one crate per engine. `crates/test-fixtures` and `crates/test-support`: test-only.
+- `crates/app`: the binary, the GTK application, its windows and views. `crates/core`: domain types and traits, no GUI. `crates/storage`: secrets, settings and files. `crates/session`, `crates/net`, `crates/ssh`: sessions, the network layer and the OpenSSH transport. `crates/drivers/*`: one crate per engine. `crates/test-fixtures` and `crates/test-support`: test-only.
 - `data/`: desktop entry, D-Bus service, metainfo, GSettings schema, icons and GResource. `po/`: translations. `build-aux/flatpak/`: the Flatpak manifest.
 - `ARCHITECTURE.md`, `CONTRIBUTING.md` and `docs/` (testing, storage, error handling, state management, adding a driver, decisions) are the reference. Read the one for the area you touch.