refactor(linux): remediation steps 31 to 39

.github/workflows/build-linux.yml

@@ -98,6 +98,14 @@ jobs:
         run: meson setup _build -Dprofile=development
       - name: Format check
         run: cargo fmt --all -- --check
+      - name: No thread-local state in app services
+        # Trackers belong to a workspace; a thread_local! registry shares
+        # one window's unsaved edits with every other window.
+        run: |
+          if grep -rn 'thread_local!' crates/app/src/services; then
+            echo "::error::crates/app/src/services must not hold thread_local! state"
+            exit 1
+          fi
       - name: Clippy
         run: meson devenv -C _build cargo clippy --locked --workspace --all-targets -- -D warnings
       - name: Clippy without default features

linux/CHANGELOG.md

@@ -10,11 +10,35 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - Password prompt on connect when the keyring holds no password, with a choice to remember it.
-- SSH tunnels through the system OpenSSH client, using your SSH agent, host aliases and jump hosts.
+- SSH tunnels through the system OpenSSH client, with your agent, host aliases and jump hosts, confirming new host keys.
 - Security group in the connect dialog: encryption mode, CA certificate, client certificate and TLS server name.
 - SQLite file chooser in the connect dialog, with New Database to create a file.
 - Results list in the SQL editor with one entry per statement, its rows affected or error, and the open transaction.
 
 ### Fixed
 
 - Format, a query opened from history and a loaded SQL file could not be undone with Ctrl+Z.
+- PostgreSQL statement timeouts showed as a plain server error when the server's messages were not in English.
+- SQL Server money and smallmoney in the SQL editor and query results showed as approximate floats.
+- Saving a SQL Server row with a char or varchar key locked the whole table until the save ended.
+- Stop could not end a SQLite statement waiting for another connection's lock.
+- A SQLite save that failed in a way SQLite rolls back itself closed the connection and its temporary tables.
+- A SQLite script ending in an unclosed comment showed later results under the first statement's columns.
+- SQLite text containing a NUL character exported as SQL that SQLite cannot read.
+- ClickHouse query or export with a FORMAT clause filled memory instead of failing.
+- ClickHouse editor tab silently lost its temporary tables and settings when the server expired its session.
+- ClickHouse DateTime values showed as UTC text when the server profile or session set ISO output.
+- ClickHouse save with an unknown outcome could read as applied because of another table's mutation.
+- A new row removed with Delete stayed in the grid while the save left it out.
+- A save that failed on a new row did not flash that row.
+- The window title showed no unsaved-changes bullet for pending structure changes.
+- `real` values showed extra digits in the grid, copies and exports, such as 0.10000000149011612 for 0.1.
+- Excel export rounded integers past 2^53 and wrote decimals as text when their column padded the scale.
+- Exported arrays wrote each row of a multi-dimensional array as a quoted string.
+- Markdown export broke its table when a column name held a pipe.
+
+### Security
+
+- CSV export did not neutralise formulas in values of a type TablePro does not recognise.
+- Format could put a space inside `+=`, `b'01'` or `@@version`, or between a MySQL function such as `GROUP_CONCAT` and its parenthesis, and change what the statement does.
+- Opening a pipe or a device as a SQL file never finished, or read past the 8 MB limit.

linux/crates/app/src/services/cell_overlay.rs

@@ -0,0 +1,14 @@
+use tablepro_core::Value;
+
+use super::change_tracker::CellState;
+
+/// One cell as the grid draws it, copied out of the tracker so a bind
+/// holds no borrow while it updates widgets.
+#[derive(Debug, Clone, PartialEq)]
+pub struct CellOverlay {
+    /// The pending edit when there is one, else the fetched value.
+    pub value: Value,
+    pub state: CellState,
+    /// The row produced the statement a save just failed on.
+    pub error_flash: bool,
+}