Skip to content

fix(plugin-firebase): show runnable examples instead of {...} - #3400

Merged
datlechin merged 1 commit into
mainfrom
fix/firebase-example-ellipsis
Oct 13, 2026
Merged

datlechin merged 1 commit into
mainfrom
fix/firebase-example-ellipsis

Conversation

@datlechin

Copy link
Copy Markdown
Member

Why

macOS Tests has failed on main since #3392. Two Firebase error messages used {...} as a placeholder in a JSON example, and EllipsisConventionTests refuses three periods in any live catalog string. The placeholder also left the user with an example they could not paste: {...} is not valid JSON.

Change

  • The raw filter refusal now shows a complete Filter object, {"unaryFilter": {"field": {"fieldPath": "email"}, "op": "IS_NULL"}}.
  • The request syntax message now shows a complete QUERY, QUERY {"structuredQuery": {"from": [{"collectionId": "users"}]}}.
  • Both examples moved out of the localized keys into %@ arguments, so a translator never edits JSON and a test runs each one. The two old keys had no translations.

Verified

EllipsisConventionTests fails on main with these two keys and finds no offender here. Two new package tests parse every example each message gives.

Signed-off-by: Ngo Quoc Dat <datlechin@gmail.com>
@datlechin
datlechin merged commit 27d00ef into main Oct 13, 2026
10 checks passed
@datlechin
datlechin deleted the fix/firebase-example-ellipsis branch October 13, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant