Repository navigation
fix(linux-core): keep a finished call from cancelling its caller - #3398
Merged
Merged
Conversation
OwnedCalls never disarmed its drop guard, so every call that returned cancelled the caller's token. A page reuses one set of options for its columns, row identity and rows, so opening a table showed "Stopped."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Opening a table in the Linux app showed "Couldn't load rows" with "Stopped." on PostgreSQL, MySQL, MariaDB, SQL Server and ClickHouse.
OwnedCallsheld a drop guard on the caller's cancel token and never disarmed it, so every call that returned cancelled the token. A page reuses one set of call options for the table's columns, row identity and rows, so the second call started cancelled.Change
Verified
A new
OwnedCallsunit test and a new conformance case,calls_share_one_call_options, fail onlinuxand pass here; the case ran against PostgreSQL in Docker and runs for every engine in CI.