Repository navigation
ci(release): ship the update archive as tar.xz - #3363
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3362.
Why
The Sparkle update archive is a deflate zip. As tar.xz, the 0.80.0 app is 21.2 MB instead of 33.9 MB on arm64 and 24.5 MB instead of 36.4 MB on x86_64, and every shipped build can install it.
Change
package-artifacts.shwritesTablePro-<arch>.tar.xzwith/usr/bin/tar(symlinks kept, no extended attributes, xz level 9) instead of the ditto zip. The DMG and plugin zips stay.verify-update-archive.sh: extracts the archive with the command Sparkle runs (/usr/bin/tar -zxC), then runscodesign --verify --deep --strict,stapler validateandspctl -a -t execon the app.sign-and-appcast.shand the upload use the tar.xz.fetch-delta-bases.shtakes whichever archive an earlier release has, so the first deltas still come from zips.Verified
Package.resolved: 2.8.1 (v0.1.1 to v0.15.0), 2.9.0 (v0.16.0 to v0.63.0), 2.9.5 (v0.64.0 to v0.74.0), 2.10.0 (v0.75.0 to v0.80.0); v0.1.0 has no Sparkle. In each,SUPipedUnarchivermaps.tar.xzto/usr/bin/tar -zxC,AppInstallerkeeps the whole.tar.xzsuffix, andtestUnarchivingTarDotXzcovers it. GitHub sendsfilename=<asset>.tar.xz, which Sparkle names the download from.package-artifacts.shon the published 0.80.0 arm64 app: 21,188,832 bytes, and the new step passes it. It fails a tampered file and a tar that follows symlinks.sign-and-appcast.shwith tar.xz archives and zip delta bases: tar.xz enclosures, release notes paired, deltas built. Nothing uploaded.Not in this PR