Repository navigation
fix(ios): refuse MySQL connections that use a Mac socket - #3321
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#3315 lets a MySQL or MariaDB connection on the Mac dial a local socket, saved in
additionalFieldsaslocalSocketPath. Connections sync to iPhone and iPad, where that socket does not exist. The iOS driver ignored the key and connected by host and port instead, usuallylocalhost, which reaches the wrong server or fails with an unrelated error.Change
MySQLLocalSocket.swift, so both apps read the key with one rule. The iOS docs list it under What is missing.Verified
MySQLVariantSupportTestsrefusal cases fail on main and pass here;ConnectionErrorClassifierTestsandConnectionFormEditsTestscover the message and the edit path.Not in this PR