Repository navigation
fix(mcp): stop counting requests without credentials toward the lockout - #3320
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Five requests without an
Authorizationheader inside 60 seconds locked every MCP client on the Mac out for 5 minutes. Every local client shares the loopback address key, so any local process could trigger it, and a client's normal probe,401challenge, retry-with-token flow (RFC 7235 §2.1) counted as a failed login.Change
Authorizationheader gets the401challenge and is no longer counted toward the auth lockout. It never reaches token validation, so it cannot be used to guess a token.Bearerscheme, and an unknown, expired or revoked token still count. An active lockout still answers429to requests without a header.Verified
MCPBearerTokenAuthenticatorTestsandMCPCompositeAuthenticatorTests: requests without a header never lock out and fail on main; bad credentials still lock out.