[BUGFIX] add upgrade wizard to migrate from v13 to v14 - #21
Merged
Merged
Conversation
sfsmfc
force-pushed
the
bugfix/v14-upgrade-wizard
branch
5 times, most recently
from
September 1, 2026 13:43
65b5c10 to
3a9b170
Compare
sfsmfc
changed the title
sfsmfc
force-pushed
the
bugfix/v14-upgrade-wizard
branch
from
September 10, 2026 21:15
3a9b170 to
cc1f3b9
Compare
- Fix isLegacyFormat() call in InstanceSecretEncryptionMigrationWizard (was $this->isLegacyFormat(), must be $this->cipherService->isLegacyFormat()) - Wrap decryptWithSodium key derivation in try/finally so sodium_memzero() is always called even if a SodiumException or JsonException is thrown - Rename phpstan.bootstrap-dashboard.php → phpstan.bootstrap-typo3stubs.php and add a cms-install autoloader shim so Classes/Upgrades/ can be included in PHPStan analysis; add CI fallback stubs for UpgradeWizardInterface and the UpgradeWizard attribute - Remove excludePaths for Classes/Upgrades/ from phpstan.neon
buchmarv
approved these changes
Sep 21, 2026
buchmarv
left a comment
buchmarv
left a comment
There was a problem hiding this comment.
I prefer baseline entries over stubs, but I guess we can keep it like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading from TYPO3 v13 to v14, instanceSecret values stored in site settings could no longer be decrypted. This caused status queries and dashboard URL fetches to silently fail, surfacing as "Status query failed" and "Dashboard URL could not be retrieved" in the backend.
Problem: The v13 fallback implementation in CipherService serialized the encrypted payload with the JSON key "ciphertext", while TYPO3 v14's CipherValue::fromSerialized() expects "cipher". Values encrypted under v13 are therefore unreadable by the v14 decryption path.