[TASK] Float images with :align: instead of float-left/float-right - #587
Merged
linawolf merged 2 commits intoOct 1, 2026
Merged
Conversation
render-guides replaces the Bootstrap 4 classes float-left and float-right with float-start and float-end, and logs a deprecation warning when a document still uses the old names (TYPO3-Documentation/render-guides#1179). This guide recommended :class: float-left as the first way to float an image, and two of its live examples used it, so the guide itself would log two warnings. The guide now recommends :align:, which render-guides already maps on both image and figure, and keeps other classes such as with-shadow in :class: next to it. The class form is float-start / float-end, with a substitution image as its example: docutils only accepts top, middle and bottom for :align: inside a substitution definition. The page also says that the old class names are deprecated. Assisted-by: Claude Opus 5 <noreply@anthropic.com> Agent-Session: https://claude.ai/code/session_019F8MxNJMzB34gc68wg6Xkv Agent-Host: 0493f0 Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
3 tasks done
CybotTM
marked this pull request as ready for review
September 26, 2026 23:30
linawolf
reviewed
Sep 29, 2026
:align: floats both image and figure, and other classes such as with-shadow sit next to it in :class:, so a separate section for the float classes only repeats it. Its one argument, the substitution image, rests on a docutils limit that render-guides does not have. The page now leads with the align option. The image-float-css-classes anchor moves there so existing links keep working, and one paragraph still names float-start / float-end and the deprecated float-left / float-right. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://claude.ai/code/session_01XzfnUQmxDxanqouHSEHHky Agent-Host: 32116e Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
linawolf
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged, the image float page recommends
:align:as the way to float an image or figure, and its live examples no longer use the Bootstrap 4 class names. Rendered with the code of TYPO3-Documentation/render-guides#1179, the guide then logs no deprecation warning; without this change it logs two.render-guides#1179 renames the float classes to Bootstrap 5's
float-start/float-end, rewrites the old names and logs a deprecation warning for them. This page recommended:class: float-leftas the first way to float an image, and examples 8 and 10 used it.Changes:
:align:is the one documented way to float. render-guidesmainalready maps it on bothimageandfigure, so the examples render the same before and after #1179. Classes such aswith-shadowstay in:class:next to it.image-float-css-classesanchor now sits on the align section, so existing links keep working. One paragraph still namesfloat-start/float-endand says thatfloat-left/float-rightare deprecated. That sentence is only true once #1179 is released, so this PR should merge after it.Images.rstlistsfloat-start/float-endunder:class:and:align:for images and figures.Testing:
make test-docswithrender-guides:latestexits 0; a full render with the same image emits no warnings and keeps bothimage-float-css-classesandimage-float-align-optionas ids on the page.main(94e9e2f) with the same renderer. The page's floated examples renderclass="with-shadow float-start"andclass="float-end".Assisted by claude-code:claude-opus-5.5 — Session