Skip to content

fix(action): fail on a reportless run and encode the baseline name - #429

Merged
TMHSDigital merged 1 commit into
TMHSDigital:mainfrom
SatriaBagusNurhadianto:fix/action-no-report-and-artifact-name
Nov 17, 2026
Merged

TMHSDigital merged 1 commit into
TMHSDigital:mainfrom
SatriaBagusNurhadianto:fix/action-no-report-and-artifact-name

Conversation

@SatriaBagusNurhadianto

Copy link
Copy Markdown
Contributor

fix(action): fail on a reportless run and encode the baseline name

What changed:

  • The scan step now exits 1 when subenum exits 0 without writing a report, instead of passing on the previous use's outputs. -dry-run and -version are the exit-0 reportless cases.
  • The baseline artifact name is URL-encoded before it goes into the gh api query, so names containing &, +, # or % resolve instead of being truncated or reinterpreted.
  • Added a CI case that runs the action with -version and asserts the step fails with no verdict output.

Why:

Tests:

  • actionlint passes on the repository.
  • go test ./internal/cli/ -run TestDocsActionPinsMatchWorkflows passes.
  • Extracted every run: block from action.yml and ran bash -n on each; all pass.

Related: #407

…MHSDigital#407)

- exit 1 when subenum exits 0 without a report (-dry-run, -version)
- URL-encode the baseline artifact name in the gh api query
- cover the exit-0 reportless case in CI
TMHSDigital added a commit that referenced this pull request Nov 17, 2026
The lab server refused every name starting with "bad", and the wildcard
probe's random label is hex, so about one probe in 4096 began with "bad",
came back REFUSED and failed the scan as inconclusive (seen on macOS in
PR #429's CI). Use "bad-" names, which a hex label cannot match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@TMHSDigital
TMHSDigital merged commit 920a78f into TMHSDigital:main Nov 17, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action: a run with no report passes on exit 0; baseline name is not URL-encoded

2 participants