Repository navigation
fix(validate): accept bare IP for -dns-server with default port 53 - #425
Merged
Merged
Conversation
2 tasks
Signed-off-by: Indra Prasetya <11029197+prascli@users.noreply.github.com>
prascli
force-pushed
the
fix/417-dns-server-bare-ip
branch
from
November 17, 2026 07:31
7923172 to
e46e3b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-dns-servernow accepts a bare IPv4 or IPv6 literal, appending port 53 the same way-rresolver files already do.1.1.1.1and2606:4700:4700::1111are normalized to1.1.1.1:53and[2606:4700:4700::1111]:53, so the CLI, TUI, MCP server, config files andpkg/subenumall accept the shorter form. Help text and the generated flag table were updated toip[:port].Related Issue
Fixes #417
Type of Change
Checklist
Ethical Considerations
Verification
All packages pass.
gofmt -l .prints nothing. Build succeeds withgo build ./....Additional Information
The change is localized to input normalization; encrypted transports and hostnames for DoT/DoH are unaffected.