Repository navigation
Ensure shortlist toggle meets touch target size - #122
Merged
TMHSDigital merged 2 commits intoOct 22, 2026
Merged
TMHSDigital merged 2 commits into
TMHSDigital merged 2 commits into
Conversation
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
…d lib.test.mjs only The file was not referenced by npm test or ci.yml, so it never ran in CI, and the repo keeps behaviour tests in the two existing files rather than regex checks on the stylesheet. The CSS fix stays as is: measured under a 390px touch viewport, the shortlist toggle grows from 19px to 45px tall with no change to the card height. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Owner
|
Thanks. The CSS change is right: measured under a 390px touch viewport, the shortlist toggle goes from 19px to 45px tall with no change to the card height (the min-height line is redundant but harmless). One request: please remove site/shortlist-touch-target.test.mjs. It is not wired into npm test or ci.yml so it never runs, and this repo keeps its tests in checks.test.mjs and lib.test.mjs rather than regex checks on the stylesheet. I have set the PR body to reference #102 so the issue closes on merge. If I do not hear back I will merge and drop the file in a follow-up. |
1 task done
jay23606
deleted the
pr-go/102-a11y-mobile-the-shortlist-toggle-in-card
branch
October 22, 2026 19:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
On touch screens, the shortlist button in a card lacked the enlarged hit area already applied to the in-card links.
Change
Give the button a 44px minimum height and check that padding is cancelled by matching negative margins so the card layout does not shift.
Testing
node site/shortlist-touch-target.test.mjsfailed against the base CSS with the missing button selector assertion and passed with the fix.Regression test: fails on base twice (/coarse-pointer styles must include .entry-links button/), passes on fix twice (
node site/shortlist-touch-target.test.mjs)Fixes #102