Skip to content

Fix volume loop on casting#154

Open
albertonantiattheo wants to merge 2 commits into
mainfrom
bugfix/volume-loop-on-casting
Open

Fix volume loop on casting#154
albertonantiattheo wants to merge 2 commits into
mainfrom
bugfix/volume-loop-on-casting

Conversation

@albertonantiattheo
Copy link
Copy Markdown

UIContainer.muted setter unconditionally writes back to player.muted on every volumechange event, creating a feedback loop when the cast receiver cannot converge on the sender's expected volume state.
This PR prevents a feedback loop during casting by guarding against redundant writes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

⚠️ No Changeset found

Latest commit: 7228a26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MattiasBuelens
Copy link
Copy Markdown
Collaborator

Huh, I would have thought the Web SDK already handled redundant writes on it own... 🤔 Could you raise this issue internally too?

Also, please add a changelog entry. See the bot's comment (above) for instructions. 😉

@albertonantiattheo
Copy link
Copy Markdown
Author

Changelog added. The topic is also tracked internally in a ticket.
Re why the player doesn't check it, I think it may be because it never came up...: the VJS UI calls setMuted only on user clicks, not for every volumechange, so it doesn't start a loop (IF I am reading this correctly, of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants