Skip to content

fix: correct command tab completion - #73

Merged
ryanbarlow97 merged 1 commit into
mainfrom
fix/command-tab-completion-20261015
Oct 15, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
fix/command-tab-completion-20261015

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Correct command suggestions to match the arguments accepted by VehicleFramework, including the current prefix and applicable permission or sender context.

  • VF-01: Every explicit candidate list is filtered case-insensitively against the current token, including templates, radii, tracks and existing takeover suffixes.
  • VF-02: Info, particles and bind now offer optional known UUIDs from the current world, matching delete and clearance.
  • VF-03: Permitted console senders receive reload/admin/track roots, admin quarantine and track resync; player-only routes are excluded.

Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed (1710 tests, zero failures, errors or skips), including command-completion regressions. git diff --check passed.

Documentation: TF-Minecraft/Docs#266.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 347cc1d6-7ecc-4fc8-af5a-122a5d58b69b
📥 Commits

Reviewing files that changed from the base of the PR and between 6716613 and 016880c.

📒 Files selected for processing: 3
  • src/main/java/net/tfminecraft/vehicleframework/util/TabCompletion.java
  • src/test/java/net/tfminecraft/vehicleframework/managers/CommandAndOwnershipCoverageTest.java
  • src/test/java/net/tfminecraft/vehicleframework/util/RuntimeUtilitiesCoverageTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Added tab-completion suggestions for track names with the info, particles and bind actions.
    • Console administrators can now receive suggestions for supported admin and track commands.
  • Bug Fixes
    • Suggestions now match the current argument prefix without regard to letter case.
    • Empty, unmatched or unauthorised requests now return no suggestions.

Tab completion now filters suggestions by the current argument, supports admin suggestions for non-player senders, and offers track names for additional subcommands. Tests cover filtering, permissions, sender types, and track suggestions.

Changes: Tab Completion

Layer / File(s) Summary
Completion filtering and suggestions
src/main/java/net/tfminecraft/vehicleframework/util/TabCompletion.java, src/test/java/net/tfminecraft/vehicleframework/managers/CommandAndOwnershipCoverageTest.java, src/test/java/net/tfminecraft/vehicleframework/util/RuntimeUtilitiesCoverageTest.java
Completion filters candidates by the current argument prefix without regard to case. Non-player senders receive specified suggestions only when they are admins. Track-name suggestions now apply to info, particles, and bind, as well as delete and clearance. Tests cover these results and empty-list behaviour.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 01688

The updated completions match the supported commands, with no actionable merge-blocking risk identified.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Oct 15, 2026
@ryanbarlow97
ryanbarlow97 marked this pull request as ready for review October 15, 2026 18:44
@ryanbarlow97
ryanbarlow97 merged commit 664d875 into main Oct 15, 2026
4 checks passed
@ryanbarlow97
ryanbarlow97 deleted the fix/command-tab-completion-20261015 branch October 15, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant