You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct command suggestions to match the arguments accepted by VehicleFramework, including the current prefix and applicable permission or sender context.
VF-01: Every explicit candidate list is filtered case-insensitively against the current token, including templates, radii, tracks and existing takeover suffixes.
VF-02: Info, particles and bind now offer optional known UUIDs from the current world, matching delete and clearance.
VF-03: Permitted console senders receive reload/admin/track roots, admin quarantine and track resync; player-only routes are excluded.
Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed (1710 tests, zero failures, errors or skips), including command-completion regressions. git diff --check passed.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
New Features
Added tab-completion suggestions for track names with the info, particles and bind actions.
Console administrators can now receive suggestions for supported admin and track commands.
Bug Fixes
Suggestions now match the current argument prefix without regard to letter case.
Empty, unmatched or unauthorised requests now return no suggestions.
Tab completion now filters suggestions by the current argument, supports admin suggestions for non-player senders, and offers track names for additional subcommands. Tests cover filtering, permissions, sender types, and track suggestions.
Changes: Tab Completion
Layer / File(s)
Summary
Completion filtering and suggestions src/main/java/net/tfminecraft/vehicleframework/util/TabCompletion.java, src/test/java/net/tfminecraft/vehicleframework/managers/CommandAndOwnershipCoverageTest.java, src/test/java/net/tfminecraft/vehicleframework/util/RuntimeUtilitiesCoverageTest.java
Completion filters candidates by the current argument prefix without regard to case. Non-player senders receive specified suggestions only when they are admins. Track-name suggestions now apply to info, particles, and bind, as well as delete and clearance. Tests cover these results and empty-list behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by VehicleFramework, including the current prefix and applicable permission or sender context.
VF-01: Every explicit candidate list is filtered case-insensitively against the current token, including templates, radii, tracks and existing takeover suffixes.VF-02: Info, particles and bind now offer optional known UUIDs from the current world, matching delete and clearance.VF-03: Permitted console senders receive reload/admin/track roots, admin quarantine and track resync; player-only routes are excluded.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (1710 tests, zero failures, errors or skips), including command-completion regressions.git diff --checkpassed.Documentation: TF-Minecraft/Docs#266.