You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct command suggestions to match the arguments accepted by TFMCWeb, including the current prefix and applicable permission or sender context.
TFMCWeb-01: Staff skin token completion remains available when ordinary create permission is added with regular skin disabled. Discord no-argument commands suppress fallback names; warning completes only its authorized target slot.
TFMCWeb-02: Staff skin token completion remains available when ordinary create permission is added with regular skin disabled. Discord no-argument commands suppress fallback names; warning completes only its authorized target slot.
Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed (180 tests, zero failures, errors or skips), including command-completion regressions. git diff --check passed.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Features
Added player-name suggestions for warning commands when the sender has permission.
Updated token command suggestions to include the staff-skin option when the relevant permissions and settings allow it.
Link and unlink commands do not offer tab-completion suggestions.
Tab completion now returns no suggestions for Discord link and unlink commands, filters online player names for the warning command, and updates token skin-route suggestions based on permissions and enabled scopes.
Link and unlink commands implement TabCompleter and return empty suggestion lists. Tests cover player and console senders and multiple argument shapes.
The warning command suggests online player names matching the first argument, without case sensitivity, when the sender has tfmcweb.warning and supplies exactly one argument. Tests cover permission, match, and argument conditions.
The skin route is suggested when the matching regular or staff permission and scope are enabled. Tests cover staff suggestions and duplicate skin suppression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:M30-99 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by TFMCWeb, including the current prefix and applicable permission or sender context.
TFMCWeb-01: Staff skin token completion remains available when ordinary create permission is added with regular skin disabled. Discord no-argument commands suppress fallback names; warning completes only its authorized target slot.TFMCWeb-02: Staff skin token completion remains available when ordinary create permission is added with regular skin disabled. Discord no-argument commands suppress fallback names; warning completes only its authorized target slot.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (180 tests, zero failures, errors or skips), including command-completion regressions.git diff --checkpassed.Documentation: TF-Minecraft/Docs#266.