Repository navigation
Add the will request routes to the realm allow-list - #38
Merged
Merged
Conversation
The ProvinceSystem will pull (GET /characters/plugin/wills/pending) now gets realm_id in its query and the ack (POST /characters/plugin/wills/applied) gets it in its body. RPCharacters passes the realm itself; this is the second guard, and an explicit realm is left untouched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ryanbarlow97
marked this pull request as ready for review
October 13, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 6b: ProvinceSystem gains a will request queue that RPCharacters pulls and acknowledges. This adds both plugin routes to
ProvinceSystemGateway's realm allow-list:GET /characters/plugin/wills/pendinggetsrealm_idin the query.POST /characters/plugin/wills/appliedgetsrealm_idin the top-level body.RPCharacters already sends
realm_id=TFMCWeb.getRealmId()on both, so this is a second guard; an explicit realm is left untouched. Tests cover injection on both routes, the explicit realm being kept, and the methods not crossing over (the pull is GET only, the ack POST only).RPCharacters reaches ProvinceSystem only through this gateway (reflectively, via its
GatewayClient), and reads the realm through the existing publicTFMCWeb.getRealmId(), so no new accessor was needed.Release note: this is intended as TFMCWeb 1.2.0.
mainalso carries #36 (resend player meta when LuckPerms permissions change), merged and unreleased, so the 1.2.0 release will include it.Gate:
mvn clean verify, 161 tests, coverage checks met.Docs: TF-Minecraft/Docs#213
🤖 Generated with Claude Code