Skip to content

Add the will request routes to the realm allow-list - #38

Merged
ryanbarlow97 merged 1 commit into
mainfrom
stage6b/will-routes
Oct 13, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
stage6b/will-routes

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Stage 6b: ProvinceSystem gains a will request queue that RPCharacters pulls and acknowledges. This adds both plugin routes to ProvinceSystemGateway's realm allow-list:

  • GET /characters/plugin/wills/pending gets realm_id in the query.
  • POST /characters/plugin/wills/applied gets realm_id in the top-level body.

RPCharacters already sends realm_id=TFMCWeb.getRealmId() on both, so this is a second guard; an explicit realm is left untouched. Tests cover injection on both routes, the explicit realm being kept, and the methods not crossing over (the pull is GET only, the ack POST only).

RPCharacters reaches ProvinceSystem only through this gateway (reflectively, via its GatewayClient), and reads the realm through the existing public TFMCWeb.getRealmId(), so no new accessor was needed.

Release note: this is intended as TFMCWeb 1.2.0. main also carries #36 (resend player meta when LuckPerms permissions change), merged and unreleased, so the 1.2.0 release will include it.

Gate: mvn clean verify, 161 tests, coverage checks met.

Docs: TF-Minecraft/Docs#213

🤖 Generated with Claude Code

The ProvinceSystem will pull (GET /characters/plugin/wills/pending) now
gets realm_id in its query and the ack (POST
/characters/plugin/wills/applied) gets it in its body. RPCharacters
passes the realm itself; this is the second guard, and an explicit realm
is left untouched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (tests excluded in mixed PRs). label Oct 13, 2026
@ryanbarlow97
ryanbarlow97 marked this pull request as ready for review October 13, 2026 18:16
@ryanbarlow97
ryanbarlow97 merged commit 402a7e8 into main Oct 13, 2026
3 checks passed
@ryanbarlow97
ryanbarlow97 deleted the stage6b/will-routes branch October 13, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant