You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Bug Fixes
Command tab completion now returns no suggestions to console and other non-player senders, including for accept and deny.
Player tab completion is unchanged: players can still see matching accept and deny options, and players with the required permission can see matching online player names.
SurgeryCommand.onTabComplete now returns no suggestions for non-player senders. Tests cover non-player senders and a player without permission.
Changes: Tab completion
Layer / File(s)
Summary
Guard tab completion by sender src/main/java/net/tfminecraft/surgery/commands/SurgeryCommand.java, src/test/java/net/tfminecraft/surgery/commands/SurgeryCommandTest.java
The command returns no suggestions for non-player senders. Tests check non-player senders and confirm that a player without permission receives matching subcommand suggestions.
Non-player senders receive no suggestions, matching the command’s player-only behavior; player suggestions preserve the distinction between consent actions and surgeon-only offers. No material merge risk remains.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by Surgery, including the current prefix and applicable permission or sender context.
SU-01: Surgery completion is player-only; existing patient visibility, permissions and consent actions are preserved.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (98 tests, zero failures, errors or skips), including command-completion regressions.git diff --checkpassed.Documentation: TF-Minecraft/Docs#266.