You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Bug Fixes
Command tab completion now filters suggestions according to the first argument, rather than showing every subcommand. Matching is case-insensitive, so entering RE suggests reload, while an unmatched prefix returns no suggestions.
Tab completion now returns subcommands that match the first argument, using case-insensitive prefix matching. The lifecycle test checks matching and non-matching inputs.
Changes: Command completion
Layer / File(s)
Summary
Filter subcommands by prefix src/main/java/net/tfminecraft/research/command/CommandManager.java, src/test/java/net/tfminecraft/research/ResearchLifecycleTest.java
onTabComplete lowercases the first argument with Locale.ROOT and returns subcommands that start with it. The test checks RE, reload, and zzz.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by Research, including the current prefix and applicable permission or sender context.
RS-01: Research completion offers reload only for matching case-insensitive prefixes and authorized senders.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (298 tests, zero failures, errors or skips), including command-completion regressions.git diff --checkpassed.Documentation: TF-Minecraft/Docs#266.