Require reviewed character ownership for legacy stations

src/main/java/net/tfminecraft/research/database/StationBackfill.java

@@ -30,7 +30,7 @@
  * as 6a did for locks and vehicles. The plan ({@code plan.json}) is written before any station changes and
  * reused after a crash; each changed station's original file is kept in {@code backup/}; {@code done.json}
  * records the result, after which later boots do nothing. Accounts without a heir keep their stations
- * unassigned (the next character on the account claims them) and are listed for staff.
+ * unassigned and unusable, and are listed for staff.
  */
 public final class StationBackfill {
     static final String FOLDER = "data/backfill-character-v1";

src/main/java/net/tfminecraft/research/manager/ResearchManager.java

@@ -173,7 +173,6 @@ public void onStationInteract(PlayerInteractEvent event) {
                 player.sendMessage(Messages.get("station.in_use"));
                 return;
             }
-            claimForActiveCharacter(station, player);
             openMainGui(player, station);
             return;
         }
@@ -739,20 +738,8 @@ private boolean isOwnedBy(ResearchStation station, Player player) {
         }
         String ownerCharacterId = station.getOwnerCharacterId();
         String activeCharacterId = playerManager.getActiveCharacterId(player);
-        return activeCharacterId != null
-                && (ownerCharacterId == null || ownerCharacterId.equalsIgnoreCase(activeCharacterId));
-    }
-
-    /** Stations saved before characters were recorded belong to the next character to open them. */
-    private void claimForActiveCharacter(ResearchStation station, Player player) {
-        if (station.getOwnerCharacterId() != null) {
-            return;
-        }
-        String characterId = playerManager.getActiveCharacterId(player);
-        if (characterId != null) {
-            station.setOwnerCharacterId(characterId);
-            StationStore.saveStation(station);
-        }
+        return ownerCharacterId != null && activeCharacterId != null
+                && ownerCharacterId.equalsIgnoreCase(activeCharacterId);
     }
 
     private boolean isMenuFor(InventoryView view, ResearchStation station) {

src/test/java/net/tfminecraft/research/manager/MultipleStationsTest.java

@@ -41,6 +41,8 @@ void scrapConfirmActsOnTheStationWhoseMenuIsOpen() {
         Location second = new Location(world, 20, 64, 20);
         ResearchStation firstStation = new ResearchStation(first, ownerId, null);
         ResearchStation secondStation = new ResearchStation(second, ownerId, null);
+        firstStation.setOwnerCharacterId(session.ref().characterId().toString());
+        secondStation.setOwnerCharacterId(session.ref().characterId().toString());
 
         Inventory top = mock(Inventory.class);
         InventoryView view = mock(InventoryView.class);

src/test/java/net/tfminecraft/research/manager/ResearchManagerTest.java

@@ -199,6 +199,7 @@ void setUp() throws Exception {
         when(lectern.getLocation()).thenReturn(location);
         project = new ActiveProject("input", "output", "vanilla.DIAMOND");
         station = new ResearchStation(location, owner, project);
+        station.setOwnerCharacterId("alice");
         points = mock(PlayerManager.class);
         when(points.getActiveCharacterId(player)).thenReturn("alice");
         MockedStatic<Characters> characters = scoped(mockStatic(Characters.class));
@@ -391,21 +392,33 @@ void startingCharacterKeepsWorkingOnItsProject() {
         assertEquals(2, project.getAspectPoints("fire"));
     }
 
-    @Test
-    void olderStationsBelongToTheNextCharacterToOpenThem() {
+    @ParameterizedTest
+    @ValueSource(strings = {"alice", "bob"})
+    void unassignedStationsCannotBeClaimedByAnActiveCharacter(String character) {
+        station.setOwnerCharacterId(null);
         when(points.getActiveCharacterId(player)).thenReturn(null);
         manager.onStationInteract(interact(Action.RIGHT_CLICK_BLOCK, lectern, EquipmentSlot.HAND));
         assertNull(station.getOwnerCharacterId());
         store.verify(() -> StationStore.saveStation(any()), never());
 
-        when(points.getActiveCharacterId(player)).thenReturn("alice");
+        when(points.getActiveCharacterId(player)).thenReturn(character);
         manager.onStationInteract(interact(Action.RIGHT_CLICK_BLOCK, lectern, EquipmentSlot.HAND));
-        assertEquals("alice", station.getOwnerCharacterId());
-        store.verify(() -> StationStore.saveStation(station));
-
         manager.onStationInteract(interact(Action.RIGHT_CLICK_BLOCK, lectern, EquipmentSlot.HAND));
-        store.verify(() -> StationStore.saveStation(station), times(1));
-        verify(menus, times(2)).openMain(player, station);
+        assertNull(station.getOwnerCharacterId());
+        store.verify(() -> StationStore.saveStation(any()), never());
+        verifyNoInteractions(menus);
+    }
+
+    @Test
+    void unassignedStationCannotSpendFocusThroughAnAlreadyOpenMenu() {
+        station.setOwnerCharacterId(null);
+        prepareExperiment("fire", "water", Map.of("fire", 10, "water", 10));
+
+        confirm();
+
+        verify(points, never()).trySpendMentalPoints(any(), anyInt());
+        assertEquals(0, project.getAspectPoints("fire"));
+        store.verify(() -> StationStore.saveStation(any()), never());
     }
 
     @ParameterizedTest

src/test/java/net/tfminecraft/research/manager/ResearchSessionTest.java

@@ -143,7 +143,7 @@ void endReturnsExperimentOnceBeforeIncomingSessionAndKeepsProgress(CharacterSess
     }
 
     @Test
-    void legacyOwnershipIsClaimedOnlyWhenReadyAndExistingCasingIsPreserved() {
+    void unassignedOwnershipCannotBeClaimedAndExistingCasingIsPreserved() {
         String original = station.getOwnerCharacterId();
         interact();
         assertEquals(original, station.getOwnerCharacterId());
@@ -156,8 +156,8 @@ void legacyOwnershipIsClaimedOnlyWhenReadyAndExistingCasingIsPreserved() {
         assertEquals("Character is loading.", player.nextMessage());
         current = ready;
         interact();
-        assertEquals(ready.ref().characterId().toString(), station.getOwnerCharacterId());
-        store.verify(() -> StationStore.saveStation(station), times(1));
+        assertNull(station.getOwnerCharacterId());
+        store.verifyNoInteractions();
     }
 
     @Test