Pass research stations on with the estate (stage 6b)

[ryanbarlow97]

When RPCharacters settles a dead character’s estate, Research transfers each station owned by that character to the property recipient, saving the new account and character atomically. A per-death journal preserves moved station IDs across crashes; failed saves restore the in-memory owner and answer RETRY. Waiting or frozen property moves nothing. Transfers require Estates.guardHolds, and reconciliation runs on the first tick and hourly with per-estate failure isolation.

Stations saved without a character receive their account’s reviewed legacy heir once at startup. This pass inventories persisted JSON ownership metadata independently of recipe/output/world validation, so unloadable stations are covered. Its durable plan fixes the original account and heir before changes; original station bytes are backed up durably, and atomic writes change only owner_character_id, preserving all other JSON fields. Replay checks location/account identity and existing claims. Invalid, missing or changed files are logged and listed for staff alongside accounts without heirs. A failed read, backup, write or completion marker leaves the plan for the next boot; completed runs are a no-op. Loaded station objects receive the same assignment.

Pins TLibs 2.6.0; capability probes preserve loading on older TLibs. Unreleased dependency pins can prevent CI resolution until publication. Related documentation: TF-Minecraft/Docs#218. Umbrella: TF-Minecraft/RPCharacters#89.

Validation: TFMC_MVN_REMOTE=1 tfmc-mvn -o -B --no-transfer-progress clean verify on the CachyOS PC passes at integrated head 8b1578acc9b6a4ea177abb43eec37fc55b68995a with 296 tests, no failures/errors, and zero missed lines. The focused regression fails before the ownership inventory fix and passes afterward. Tests cover estate transfer/replay, atomic saves, unloadable station ownership, unknown field preservation, exact original backups, immutable heir replay, changed account/claim refusal, invalid ownership reporting, write/marker failures, and subsequent-boot no-op. The previously installed/lab-confirmed 1.3.0 candidate from 44a35f1 passed its full 295-test gate before local Maven installation; the root workflow owns the final release build after this source integration.

The separately reviewed filesystem-order fix #19 is merged at c65892d47a79b426938c0a3f8ef083d0a2b33259 and included here through a normal merge from main. Combined tree 19c5ff8a8dbd8af654b0a18a5da6a6358c6e2fdb exactly matches the earlier isolated combined proof, and the fresh full CachyOS gate passes. This PR remains draft pending publication of TLibs 2.6.0 and current-head CI verification by the root workflow.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}