You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove obsolete pet and animal exclusion from wills - #112
The will screen no longer says pets and animals are excluded from estates. Holdings continue to come from registered estate participants, so the display reflects the ownership systems currently available.
Validation: Java 21 tfmc-mvn -o -B clean verify passed 2,295 tests and all configured coverage gates. The existing will workflow test also verifies pet and animal holding labels. Independent source review approved the change.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Changes
The will menu no longer displays a message about pets and animals being excluded.
Estate holdings and heir information remain unchanged.
The will menu no longer displays the notice that pets and animals are excluded. The test now checks that pet and animal holdings appear alongside the existing holding.
Changes: Will menu holdings
Layer / File(s)
Summary
Update holdings display and test src/main/java/net/tfminecraft/rpcharacters/will/WillMenu.java, src/test/java/net/tfminecraft/rpcharacters/will/WillMenuTest.java
The menu no longer displays the exclusion notice. The test checks that pet and animal holdings appear alongside the existing holding.
The obsolete exclusion notice is removed, and the menu continues to display holdings supplied by registered estate participants. No concrete merge-blocking issue is established; actual registration by external pet or animal plugins remains unverified.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The will screen no longer says pets and animals are excluded from estates. Holdings continue to come from registered estate participants, so the display reflects the ownership systems currently available.
Part of stage 6c in #89. Documentation: TF-Minecraft/Docs#226.
Validation: Java 21
tfmc-mvn -o -B clean verifypassed 2,295 tests and all configured coverage gates. The existing will workflow test also verifies pet and animal holding labels. Independent source review approved the change.