Skip to content

Remove obsolete pet and animal exclusion from wills - #112

Merged
ryanbarlow97 merged 1 commit into
mainfrom
stage6c/estate-display
Oct 14, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
stage6c/estate-display

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

The will screen no longer says pets and animals are excluded from estates. Holdings continue to come from registered estate participants, so the display reflects the ownership systems currently available.

Part of stage 6c in #89. Documentation: TF-Minecraft/Docs#226.

Validation: Java 21 tfmc-mvn -o -B clean verify passed 2,295 tests and all configured coverage gates. The existing will workflow test also verifies pet and animal holding labels. Independent source review approved the change.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6474de78-2033-4862-ab69-a7304ca1e170
📥 Commits

Reviewing files that changed from the base of the PR and between 65b77a3 and 05b3b53.

📒 Files selected for processing: 2
  • src/main/java/net/tfminecraft/rpcharacters/will/WillMenu.java
  • src/test/java/net/tfminecraft/rpcharacters/will/WillMenuTest.java
💤 Files with no reviewable changes: 1
  • src/main/java/net/tfminecraft/rpcharacters/will/WillMenu.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Changes
    • The will menu no longer displays a message about pets and animals being excluded.
    • Estate holdings and heir information remain unchanged.

The will menu no longer displays the notice that pets and animals are excluded. The test now checks that pet and animal holdings appear alongside the existing holding.

Changes: Will menu holdings

Layer / File(s) Summary
Update holdings display and test
src/main/java/net/tfminecraft/rpcharacters/will/WillMenu.java, src/test/java/net/tfminecraft/rpcharacters/will/WillMenuTest.java
The menu no longer displays the exclusion notice. The test checks that pet and animal holdings appear alongside the existing holding.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 05b3b

The obsolete exclusion notice is removed, and the menu continues to display holdings supplied by registered estate participants. No concrete merge-blocking issue is established; actual registration by external pet or animal plugins remains unverified.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (tests excluded in mixed PRs). label Oct 13, 2026
@ryanbarlow97
ryanbarlow97 marked this pull request as ready for review October 14, 2026 00:38
@ryanbarlow97
ryanbarlow97 merged commit 738d3ec into main Oct 14, 2026
4 checks passed
@ryanbarlow97
ryanbarlow97 deleted the stage6c/estate-display branch October 14, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant