Skip to content

fix(servers): fetch fresh inventory without caches - #233

Merged
ryanbarlow97 merged 3 commits into
mainfrom
fix/servers-fresh-checks
Oct 15, 2026
Merged

ryanbarlow97 merged 3 commits into
mainfrom
fix/servers-fresh-checks

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The Servers panel can report old release information until its cache expires, and Dev currently has no effective GitHub token. Every load and Check again now reads GitHub and the mounted server files afresh, with no response cache, background refresh or hash memo. Deployment scope is Main only. Dev token configuration was cancelled by the user; its private staging was removed. Host Compose files remain unchanged by this PR.

Fresh checks overlap local inventory with bounded GitHub queries, compare commit IDs before requesting branch comparisons, and resolve older installed jars by exact tags before selectively paging history. GitHub’s designated Latest release is authoritative, with history fallback for a jarless Latest. Missing checksums, interrupted history and GitHub failures stay Unverified; they cannot prove a test build. The browser preserves the previous result’s own timestamp on failure and rejects out-of-order responses.

Release plans perform their own check and pass the exact inventory baseline to the helper. The optional field preserves old-client compatibility; new clients fail closed against an old helper. Deploy the reviewed helper through its existing updater after the main push Build succeeds. No Minecraft restart is part of this change.

Validation:

  • 110 focused server/backend tests passed, including fresh calls, pagination, unavailable history, renamed plugins, changed baselines and a trickling HTTP deadline.
  • Frontend lint, formatting, typecheck and full suite passed: 2,270 tests, 1 skipped.
  • Ten read-only production comparisons preserved all 39 plugin classifications. Median fresh check: 5.66s before, 3.26s after.
  • Full Actions Build passed: 2,359 backend tests, 1 skipped, 175 subtests; full Next.js build passed. The following commit only removes the attempted change to protected Compose configuration.
  • Independent final code review found no remaining issues.
  • Branch preview startup is blocked by an existing unreadable private database backup in its data-copy step; read-only production inventory comparisons and deployed Main checks provide runtime validation.

Documentation: TF-Minecraft/Docs#270 and TF-Minecraft/Docs#272

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 028acf7d-3fb2-4883-9d35-5f7f4b17c750
📥 Commits

Reviewing files that changed from the base of the PR and between ab3f4f2 and 98b0972.

📒 Files selected for processing: 9
  • backend/src/servers/control.py
  • backend/src/servers/host.py
  • backend/src/servers/inventory.py
  • backend/src/servers/test_control.py
  • backend/src/servers/test_inventory.py
  • frontend/app/components/admin/ServersOverview.test.tsx
  • frontend/app/components/admin/ServersOverview.tsx
  • frontend/lib/admin/servers.test.ts
  • frontend/lib/admin/servers.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 1b27d54 into main Oct 15, 2026
4 of 6 checks passed
@ryanbarlow97
ryanbarlow97 deleted the fix/servers-fresh-checks branch October 15, 2026 21:45

This branch was successfully deployed

No deployments
preview — 98b0972a Deployed Oct 15, 2026 by ryanbarlow97 via deploy #442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant