You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
New Features
Command suggestions now match typed prefixes without regard to letter case.
Players receive trade ID suggestions for delete and reset commands, filtered to match the text already entered. Unknown prefixes return no trade ID suggestions.
Non-player senders are offered only the reload subcommand. Players continue to see the available subcommands, subject to existing command and permission checks.
Tab completion now restricts first-argument suggestions for non-player senders and filters player trade ID suggestions by command and case-insensitive prefix. The updated test covers these rules and permission checks.
Changes: Tab completion
Layer / File(s)
Summary
Completion rules and validation src/main/java/net/tfminecraft/marketblock/manager/commands/TabCompletion.java, src/test/java/net/tfminecraft/marketblock/manager/MarketCommandsTest.java
First-argument matching uses Locale.ROOT. Non-player senders receive only reload. Players using delete or reset receive trade IDs that match the typed prefix. Tests cover sender types, prefix matching, and permission checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by MarketBlock, including the current prefix and applicable permission or sender context.
MB-01: Trade IDs are prefix-filtered without losing their spelling; console completes reload only, while editing actions are player-only.MB-02: Trade IDs are prefix-filtered without losing their spelling; console completes reload only, while editing actions are player-only.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (147 tests, zero failures, errors or skips), including command-completion regressions.git diff --checkpassed.Documentation: TF-Minecraft/Docs#266.