You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Bug Fixes
Non-admin senders no longer receive command suggestions.
The select command and project-name suggestions are now limited to player senders; non-player senders no longer see select among first-argument suggestions.
Admins retain suggestions for available commands, and players can receive project-name suggestions with prefix filtering and a 40-result limit.
Tab completion now returns no suggestions to senders without admin permission. It excludes select for non-player senders and restricts project-name completion to players. Tests cover these checks and project-name filtering.
Changes: Tab completion
Layer / File(s)
Summary
Permission and sender checks src/main/java/net/tfminecraft/geminfusion/CommandManager.java, src/test/java/net/tfminecraft/geminfusion/LifecycleCommandsTest.java
Non-admin senders receive no suggestions. First-argument suggestions exclude select for non-player senders, and project-name completion is restricted to players. Tests cover admin suggestions, the 40-result limit, and prefix filtering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by GemInfusion, including the current prefix and applicable permission or sender context.
GEMINFUSION-01: Only admins get command suggestions; console can complete reload, while jewelry project selection is player-only.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (112 tests, zero failures, errors or skips), including command-completion regressions.git diff --checkpassed.Documentation: TF-Minecraft/Docs#266.