Skip to content

fix: correct command tab completion - #43

Merged
ryanbarlow97 merged 1 commit into
mainfrom
fix/command-tab-completion-20261015
Oct 15, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
fix/command-tab-completion-20261015

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Correct command suggestions to match the arguments accepted by GemInfusion, including the current prefix and applicable permission or sender context.

  • GEMINFUSION-01: Only admins get command suggestions; console can complete reload, while jewelry project selection is player-only.

Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed (112 tests, zero failures, errors or skips), including command-completion regressions. git diff --check passed.

Documentation: TF-Minecraft/Docs#266.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 09c2e25d-0ab7-4577-8cdd-95e56d0bc64c
📥 Commits

Reviewing files that changed from the base of the PR and between f166c40 and 7708c04.

📒 Files selected for processing: 2
  • src/main/java/net/tfminecraft/geminfusion/CommandManager.java
  • src/test/java/net/tfminecraft/geminfusion/LifecycleCommandsTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Non-admin senders no longer receive command suggestions.
    • The select command and project-name suggestions are now limited to player senders; non-player senders no longer see select among first-argument suggestions.
    • Admins retain suggestions for available commands, and players can receive project-name suggestions with prefix filtering and a 40-result limit.

Tab completion now returns no suggestions to senders without admin permission. It excludes select for non-player senders and restricts project-name completion to players. Tests cover these checks and project-name filtering.

Changes: Tab completion

Layer / File(s) Summary
Permission and sender checks
src/main/java/net/tfminecraft/geminfusion/CommandManager.java, src/test/java/net/tfminecraft/geminfusion/LifecycleCommandsTest.java
Non-admin senders receive no suggestions. First-argument suggestions exclude select for non-player senders, and project-name completion is restricted to players. Tests cover admin suggestions, the 40-result limit, and prefix filtering.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 7708c

Suggestions are limited to commands and arguments the sender can use. No identified issue currently blocks merging.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (tests excluded in mixed PRs). label Oct 15, 2026
@ryanbarlow97
ryanbarlow97 marked this pull request as ready for review October 15, 2026 18:44
@ryanbarlow97
ryanbarlow97 merged commit d2725cb into main Oct 15, 2026
4 checks passed
@ryanbarlow97
ryanbarlow97 deleted the fix/command-tab-completion-20261015 branch October 15, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant