Skip to content

Send the find and the spent counter as one line - #26

Merged
ryanbarlow97 merged 2 commits into
mainfrom
one-line-collection
Oct 15, 2026
Merged

ryanbarlow97 merged 2 commits into
mainfrom
one-line-collection

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Finding a source sent two chat lines, "You have found the source of Arcane Radiation!" and then "Your Trace Detector has run out of fuel...". They now go out as one shorter line, "You found the arcane source! Your detector is spent.": found-source then dead-geiger with a space between, each in its own colours. A blank one is left out, so either half can be turned off in messages.yml.

The spent-counter text no longer depends on the dead counter item being created. The live counter is always used up, so the line is true either way.

mvn clean verify passes with 122 tests and 100% coverage. Docs: TF-Minecraft/Docs#259.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Oct 15, 2026
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c5b81de-3609-4485-bc98-982c721fe07a
📥 Commits

Reviewing files that changed from the base of the PR and between ce8100a and 4ebe8de.

📒 Files selected for processing: 3
  • src/main/java/net/tfminecraft/geigercounters/handlers/SourceHandler.java
  • src/main/resources/messages.yml
  • src/test/java/net/tfminecraft/geigercounters/handlers/SourceHandlerTest.java
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ryanbarlow97
ryanbarlow97 merged commit c7a938e into main Oct 15, 2026
3 checks passed
@ryanbarlow97
ryanbarlow97 deleted the one-line-collection branch October 15, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant