Treat a null shared display name as no character name

[ryanbarlow97]

Follow-up to #39 (released as v0.4.0). A null display name from Characters.displayName reached isBlank(), threw, and logged the "Shared character names skipped" warning for something that is not a failure. RpNames now treats null like a blank name and falls back to the account name without logging.

An online player with RPCharacters data but no active character still shows RPCharacters' no-character label (Unknown by default), the same label chat uses; that is now documented rather than changed.

Verified with mvn clean verify: 1129 tests pass and RpNames is fully covered.

Docs: TF-Minecraft/Docs#175

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: a84347b2-c6fa-416c-b2a1-c5a9903f1535

---

📥 Commits

Reviewing files that changed from the base of the PR and between 750447a and 264bddf.

---

📒 Files selected for processing (2)

• src/main/java/net/tfminecraft/games/voice/RpNames.java
• src/test/java/net/tfminecraft/games/voice/VoiceIntegrationTest.java

---

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

---

📝 Summary

Summary by CodeRabbit

• Bug Fixes
  • Prevented an error when a character’s display name is null; the account name is used as a fallback instead.

Walkthrough

characterDisplay now handles null display names in the same way as blank display names. The integration test checks that both cases fall back to the account name without logging.

Changes

Display name fallback

Layer / File(s)	Summary
Null-safe fallback and validation src/main/java/net/tfminecraft/games/voice/RpNames.java, src/test/java/net/tfminecraft/games/voice/VoiceIntegrationTest.java	characterDisplay checks for null before checking whether the display name is blank. The integration test checks the account-name fallback for null and blank display names and verifies that no warning is logged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

---

Merge Risk: ⚪ Minimal · up to 264bd

The null shared-name case falls back to the account name without the prior warning. The separate no-active-character label depends on an external API contract that could not be verified, and no actionable defect is established.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}