Repository navigation
Document shared character sessions in Gathering and GunsAndGadgets - #161
Merged
Merged
Conversation
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document Gathering and GunsAndGadgets using the shared character session API. Gathering keeps its existing discovery UUIDs and attribute probability calculation; its direct RPCharacters dependency remains only for the creation-layer attributes. GunsAndGadgets cancels and refunds outgoing reloads before inventory saves, validates captured sessions for delayed work, and no longer depends on RPCharacters directly.
Pin the documented provider versions and add runtime verification for readiness, inventory ownership and shutdown order. Implementations: TF-Minecraft/Gathering#9 and TF-Minecraft/GunsAndGadgets#37. Part of TF-Minecraft/RPCharacters#89.
Validation: five documentation tests, 820 local links/anchors across 209 pages, and the strict CoreProtect MkDocs build passed.