You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct command suggestions to match the arguments accepted by CoreProtect, including the current prefix and applicable permission or sender context.
COREPROTECT-1: Added permission/context-aware teleport, give, preview apply/cancel and network-debug canonical roots for co/core/coreprotect.
COREPROTECT-2: Teleport/tp complete loaded worlds and existing wid IDs; coordinate positions return explicit empty results. Names containing spaces use an existing wid ID.
COREPROTECT-3: Console completion includes authorized commands and console-only consumer pause/resume; near requires a located player/command-block sender and either lookup execution permission.
COREPROTECT-4: Whitespace action values filter the current token and omit the already-entered marker; inline values retain their marker.
COREPROTECT-5: User/action/include/exclude comma lists preserve completed text and match the final value; whitespace user/material continuations return only the current replacement token. Rollback action lists stay unsupported.
COREPROTECT-6: Include/exclude values add valid entity types present in the identifier cache, and exclusions add online player names; purge excludes entity/player candidates.
COREPROTECT-7: Purge include values require purge permission rather than unrelated lookup/rollback/restore permission.
COREPROTECT-8: Purge completion tracks remaining time/radius/include parameters and #optimize across accepted aliases, argument orders and depths; unhandled positions return empty lists rather than blank-string candidates.
COREPROTECT-9: Parameter dispatch checks the selected command permission; action values match lookup subpermissions or rollback/restore capabilities, excluding purge actions and incompatible skill action lists.
COREPROTECT-10: Added reload help topic and deduplicated #silent/#verbose modifiers for lookup/rollback/restore, preserving current-token completion and restricting preview to supported player commands.
Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed (41 tests, zero failures/errors/skips), including command-completion regressions. Existing coverage gates and git diff --check passed.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Improvements
Command suggestions now adapt to sender permissions, configuration and command type, including teleport and consumer subcommands.
Lookup, rollback, restore and purge completions better reflect supported actions, parameter order, preview state and repeated or list-based inputs.
Material suggestions include cached entity types, and online players are available for exclusions.
Unhandled or unavailable completions now return empty suggestions rather than placeholder values.
Tab completion now supports additional sender types, sender- and permission-dependent root suggestions, and command-specific argument suggestions. Parameter tracking handles modifiers and comma-separated values. Tests cover permissions, aliases, senders and argument forms.
Changes: Tab completion
Layer / File(s)
Summary
Sender-aware entry and root suggestions src/main/java/net/tfminecraft/coreprotect/command/TabHandler.java, src/test/java/net/tfminecraft/coreprotect/command/TabHandlerTest.java
The completion entry point handles non-player senders and returns empty lists when no suggestions apply. Root suggestions depend on sender type, permissions, configuration and rollback preview state. Tests cover root aliases, sender access and preview-dependent options.
Parameter tracking and command-specific modifiers src/main/java/net/tfminecraft/coreprotect/command/TabHandler.java, src/test/java/net/tfminecraft/coreprotect/command/TabHandlerTest.java
Parameter tracking recognises verbose, silent and optimize modifiers. Lookup and purge suggestions account for command type, sender and parameters already present. Tests cover lookup aliases, permissions and modifier suggestions.
Action, world and value completions src/main/java/net/tfminecraft/coreprotect/command/TabHandler.java, src/test/java/net/tfminecraft/coreprotect/command/TabHandlerTest.java
Action suggestions are filtered by command and permission. Teleport, page, radius, material and entity completions use prefix- and list-aware handling. Tests cover action filtering, world names, exclusions and comma-separated values.
This change improves command tab completion to respect senders, permissions and arguments. No concrete merge-blocking risk was identified in the reviewed context.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:L100-499 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by CoreProtect, including the current prefix and applicable permission or sender context.
COREPROTECT-1: Added permission/context-aware teleport, give, preview apply/cancel and network-debug canonical roots for co/core/coreprotect.COREPROTECT-2: Teleport/tp complete loaded worlds and existing wid IDs; coordinate positions return explicit empty results. Names containing spaces use an existing wid ID.COREPROTECT-3: Console completion includes authorized commands and console-only consumer pause/resume; near requires a located player/command-block sender and either lookup execution permission.COREPROTECT-4: Whitespace action values filter the current token and omit the already-entered marker; inline values retain their marker.COREPROTECT-5: User/action/include/exclude comma lists preserve completed text and match the final value; whitespace user/material continuations return only the current replacement token. Rollback action lists stay unsupported.COREPROTECT-6: Include/exclude values add valid entity types present in the identifier cache, and exclusions add online player names; purge excludes entity/player candidates.COREPROTECT-7: Purge include values require purge permission rather than unrelated lookup/rollback/restore permission.COREPROTECT-8: Purge completion tracks remaining time/radius/include parameters and #optimize across accepted aliases, argument orders and depths; unhandled positions return empty lists rather than blank-string candidates.COREPROTECT-9: Parameter dispatch checks the selected command permission; action values match lookup subpermissions or rollback/restore capabilities, excluding purge actions and incompatible skill action lists.COREPROTECT-10: Added reload help topic and deduplicated #silent/#verbose modifiers for lookup/rollback/restore, preserving current-token completion and restricting preview to supported player commands.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (41 tests, zero failures/errors/skips), including command-completion regressions. Existing coverage gates andgit diff --checkpassed.Documentation: TF-Minecraft/Docs#266.