You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct command suggestions to match the arguments accepted by CompanionPets, including the current prefix and applicable permission or sender context.
CP-01: Owner completion verifies directory identity and uses unique executable single-token names or character UUIDs for multiword, duplicate or reserved names. Unresolved owners are omitted. Online create targets require current living identity; account aliases that collide with duplicate names use UUIDs. Executor parsing semantics are preserved.
CP-02: The executable list unassigned keyword appears only in list argument two, with permission and prefix filtering, without colliding with a character literally named unassigned.
The three skips are unchanged opt-in deployed-config comparisons requiring local configuration properties; all 46 focused completion/ownership/lifecycle regressions passed with zero skips.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Bug Fixes
Owner suggestions now use character names only when they uniquely identify the character; ambiguous or unsuitable names are shown as UUIDs instead.
Creation suggestions exclude dead characters and names that cannot be reliably matched to an owner.
Added unassigned as a completion option when listing owners.
Staff owner completion now uses validated character names or UUIDs. Create suggestions also check online character sessions and exclude dead characters. List completion includes unassigned; find and create completion do not.
Owner suggestions use a character name only when it resolves uniquely to the same identity and meets the name restrictions; otherwise, they use the UUID. Create suggestions also validate eligible online character sessions. Tests cover duplicate and multi-word names, dead characters, UUID resolution, and unassigned completion for list commands.
This change adjusts command tab completion for owner names and the unassigned keyword. It does not alter command execution, and no merge-blocking risk was found.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by CompanionPets, including the current prefix and applicable permission or sender context.
CP-01: Owner completion verifies directory identity and uses unique executable single-token names or character UUIDs for multiword, duplicate or reserved names. Unresolved owners are omitted. Online create targets require current living identity; account aliases that collide with duplicate names use UUIDs. Executor parsing semantics are preserved.CP-02: The executable list unassigned keyword appears only in list argument two, with permission and prefix filtering, without colliding with a character literally named unassigned.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (1051 tests, zero failures/errors; 3 skips), including command-completion regressions.git diff --checkpassed.The three skips are unchanged opt-in deployed-config comparisons requiring local configuration properties; all 46 focused completion/ownership/lifecycle regressions passed with zero skips.
Documentation: TF-Minecraft/Docs#266.