Skip to content

fix: correct command tab completion - #14

Merged
ryanbarlow97 merged 1 commit into
mainfrom
fix/command-tab-completion-20261015
Oct 15, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
fix/command-tab-completion-20261015

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Correct command suggestions to match the arguments accepted by BreedingBuddies, including the current prefix and applicable permission or sender context.

  • BREEDINGBUDDIES-01: Animal suggestions intersect the loaded top-level bundle keys with spawnable Bukkit Animals types and refresh with reload.
  • BREEDINGBUDDIES-02: Every existing animal/mount numeric preset is prefix filtered; freely entered numbers still execute.

Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed (248 tests, zero failures, errors or skips), including command-completion regressions. git diff --check passed.

Documentation: TF-Minecraft/Docs#266.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bae1a350-462f-414c-bed0-eae89ad42e79
📥 Commits

Reviewing files that changed from the base of the PR and between 13141c6 and 67b5ce6.

📒 Files selected for processing: 2
  • src/main/java/net/tfminecraft/breedingbuddies/BreedingBuddies.java
  • src/test/java/net/tfminecraft/breedingbuddies/BreedingBuddiesTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Improvements
    • Tab-completion suggestions for spawnable animals now reflect the current bundle configuration and match prefixes regardless of letter case.
    • Friendship, genetics, health, speed and jump preset suggestions now narrow to those matching the entered prefix.
    • Numeric values not listed as presets remain accepted when using the spawn command.

Tab completion now filters animal suggestions using spawnability and configured bundle entries. It also filters friendship, genetics, health, speed and jump presets by the entered prefix.

Changes: Tab-completion filtering

Layer / File(s) Summary
Suggestion filtering and validation
src/main/java/net/tfminecraft/breedingbuddies/BreedingBuddies.java, src/test/java/net/tfminecraft/breedingbuddies/BreedingBuddiesTest.java
Animal suggestions are limited to spawnable entity types with matching top-level bundle entries. Preset suggestions match the entered prefix. Tests cover configuration reloads, case-insensitive matching, numeric argument positions and accepted non-preset values.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 67b5c

This change makes command suggestions match the entered prefix and the loaded animal configuration. No actionable merge-blocking risk was identified.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Oct 15, 2026
@ryanbarlow97
ryanbarlow97 marked this pull request as ready for review October 15, 2026 18:44
@ryanbarlow97
ryanbarlow97 merged commit f46de40 into main Oct 15, 2026
4 checks passed
@ryanbarlow97
ryanbarlow97 deleted the fix/command-tab-completion-20261015 branch October 15, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant