You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct command suggestions to match the arguments accepted by BreedingBuddies, including the current prefix and applicable permission or sender context.
BREEDINGBUDDIES-01: Animal suggestions intersect the loaded top-level bundle keys with spawnable Bukkit Animals types and refresh with reload.
BREEDINGBUDDIES-02: Every existing animal/mount numeric preset is prefix filtered; freely entered numbers still execute.
Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed (248 tests, zero failures, errors or skips), including command-completion regressions. git diff --check passed.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Improvements
Tab-completion suggestions for spawnable animals now reflect the current bundle configuration and match prefixes regardless of letter case.
Friendship, genetics, health, speed and jump preset suggestions now narrow to those matching the entered prefix.
Numeric values not listed as presets remain accepted when using the spawn command.
Tab completion now filters animal suggestions using spawnability and configured bundle entries. It also filters friendship, genetics, health, speed and jump presets by the entered prefix.
Changes: Tab-completion filtering
Layer / File(s)
Summary
Suggestion filtering and validation src/main/java/net/tfminecraft/breedingbuddies/BreedingBuddies.java, src/test/java/net/tfminecraft/breedingbuddies/BreedingBuddiesTest.java
Animal suggestions are limited to spawnable entity types with matching top-level bundle entries. Preset suggestions match the entered prefix. Tests cover configuration reloads, case-insensitive matching, numeric argument positions and accepted non-preset values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by BreedingBuddies, including the current prefix and applicable permission or sender context.
BREEDINGBUDDIES-01: Animal suggestions intersect the loaded top-level bundle keys with spawnable Bukkit Animals types and refresh with reload.BREEDINGBUDDIES-02: Every existing animal/mount numeric preset is prefix filtered; freely entered numbers still execute.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (248 tests, zero failures, errors or skips), including command-completion regressions.git diff --checkpassed.Documentation: TF-Minecraft/Docs#266.