Send waiting letters on with the estate (stage 6b)

[ryanbarlow97]

Stage 6b (estates and wills, umbrella TF-Minecraft/RPCharacters#89): BirdMessenger becomes the birdmessenger estate participant (design D8, R17, M7).

Sending character. New letters record senderCharacterId in both serialisations, in-flight StoredMail (sender-character) and the pending letter maps, so it survives addPending. Queued letters also keep the mail's ID.

Settle. For the testator's pending letters:

• letters recipient CHARACTER (will heir): re-keyed, characterId and ownerUuid, to the heir and delivered as normal mail;
• SENDER, with senderCharacterId and that character alive: back into its pending queue, delivered with "Returned: the recipient has died";
• SENDER, older letter with only the sender account: into a new account-keyed returned queue (returned_mail.yml), delivered at the account's next character session with "Returned";
• SENDER, writing character dead or unknown, no sender, or the testator's own unsent letter: left in the testator's queue and listed by describe() (writer's character name, never a UUID) for /estate show; it goes back by itself if the writer is revived. DONE counts only moved letters.

Each moved letter gets a stored ID first (saved before anything moves), and estates/<deathId>.yml lists the IDs before the queue changes, so DONE always carries every moved ID (M12). A move is all or nothing: receiving queues are checked first, a failed save puts every queue back in memory and the participant answers RETRY. Mail files are written whole (temp, fsync, atomic move, folder fsync). The account queue is saved before the testator's queue drops a letter; load discards a copy left behind by a crash in between. In-flight letters are untouched; the hourly reconcile moves them once they land.

Reconcile and probes. The participant registers after mail loads and only when TLibs has the estate API (Class.forName probe), settles every decided estate on the first tick and hourly, and reports with the revision answered, only when the outcome changes. On TLibs 2.5.0, BirdMessenger, MailStore and MailService load and verify without the estate classes; the plugin enables and logs that it does not take part.

Pins TLibs 2.6.0, which is not released yet, so CI may fail resolving it until it is.

Docs: TF-Minecraft/Docs#220

Review. Muse's findings 1-6 are all addressed (5cf2d2b, 48784d5).

Tests. tfmc-mvn -o -B --no-transfer-progress clean verify: 247 tests, 0 failures, JaCoCo line gate (0 missed) met. Behaviour tests cover the sending character through flight and the queue, ID assignment, heir moves, returns to the writing character and to the account, every held case, revival of a held writer, idempotent and cumulative settles, a late landing letter, the crash between the two files, damaged returned queues, failed hand-overs, journal failures, describe, change-only reporting, registration, the probe and enabling without the estate API.

🤖 Generated with Claude Code

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}