Move old armour to the new looks and keep item data through refreshes

[XxFran10xX]

Armour crafted before the per-recipe models (#36) still wears the old shared look of its metal: iron is vanilla chainmail, steel is vanilla iron, bronze is bronze_*, abyssalite is netherite, mythril is diamond, infantry is the paper pumpkin and gold, and mage is iron_mage_*. This moves those pieces to their recipe's current model when they are refreshed, without touching their data. It also fixes two ways the existing refresh and ItemsAdder could damage items.

Changes

• Look migration (ArmourLookMigrator, run by the existing join, ender chest, opened storage, click and equip refresh). A recorded craft that still wears its old default look gets the model for its recipe, e.g. light_helmet gets ia.tfmc_armor:iron_light_helmet. The change goes through ArmorMerger, the same merge skins use, so stats, gems, sockets, lore, durability and name stay. The old default is the scheme's type model (helmet, ...), or the recipe's entry in armour-look-migration.legacy-models for looks that came from another ingredient (infantry paper, mage dust). Any other look is a skin and is kept. The old look is stored in ac_previous_model and logged as [AC][LookMigration]. Every recorded craft also gets its ac_craft_model_scheme tag, which ArmourShop's metal skin lines read. Off unless armour-look-migration.enabled: true.
• Stat refresh keeps the item's own data (RefreshKeeper). CraftStatRefresher rebuilt outdated items from their MMOItems data only. On TFMCDev01 that repaired them to full durability, reset ArmourShop names, dropped the skin's itemsadder compound, and dropped geminfusion:socket_rarities and tlibs:socket_overrides. The damage taken now carries over (scaled to the new maximum, never breaking an item). The skin, material, model, leather colour, display name and every persistent data key the rebuild does not set come back.
• ItemsAdder auto_update opt-out (IaAutoUpdate). ItemsAdder rebuilds an item from its definition when the definition's base properties hash no longer matches what it stored for that player slot. That rebuild keeps only amount, durability, persistent data, trim, name and enchantments, so a crafted piece wearing an ItemsAdder look loses its MMOItems data (the 2026-10-03 incident). Crafted pieces with an ItemsAdder look now get itemsadder.override_auto_update: true, which ItemsAdder honours. NBTAPI is a provided dependency and a softdepend.
• One broken item (e.g. a recorded craft whose MMOItems data is gone) no longer stops a join sweep, and a malformed v. model path no longer throws.
• ModelApplier holds the model path code that CraftingStation and the migration share.

Testing

• mvn verify: all tests pass and coverage stays at 100% (the Windows-only EdgeCoverageTest/StationDatabaseCoverageTest failures also happen on main).
• TFMCDev01, test bots with exact copies of Main armour: 18/18 pieces per bot. Every metal, weight, infantry, mage, alloy and ender chest piece got its new look with only the look fields and AC tags changed. A skinned piece and a premade piece were left alone. Results held after iareload, after a restart and on a second pass. A chest piece migrated when the chest was opened.
• Outdated-revision path: wear (e.g. 478/500), names, gems and socket data are kept.
• ItemsAdder definition change (icon swap + iareload): an unprotected copy of a skinned helmet was wiped, while the protected copy stayed intact.
• Full rehearsal with Main's live configs and all 140 Main players holding crafted or skinned gear (3,442 items): 185 pieces migrated, 146 skins kept, 408 crafts tagged, 324 ItemsAdder looks protected, nothing lost. Items Main's current refresh would damage on next login (3 longbows lose their names, 2 are repaired, 2 lose their look) keep all of it with this change.

Stacked on #37 (and #36); retarget to main once those merge.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 05c6b376-136e-42d6-9a6c-50c44f0dcce1

---

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}