Repository navigation
rename to @superinstance/quilt-evolve, and un-break the build - #4
Merged
Merged
Conversation
THREE fixes, and only the first is about the scope. 1. The scope. @quilt is not a scope this fleet owns -- it belongs to quiltdata, a different organisation -- so this package could never be published under that name. name @quilt/evolve -> @superinstance/quilt-evolve dependencies "@quilt/core": "workspace:*" -> "@superinstance/quilt-core": "^0.3.3" "@quilt/ai": "workspace:*" -> "@superinstance/quilt-ai": "^0.1.0" "workspace:*" could not install standalone at all (EUNSUPPORTEDPROTOCOL), and it formed a dependency CYCLE with quilt-ai (ai -> evolve -> ai). Both dependencies are now real ranges against packages we own, both published, and the cycle is broken. 2. The lockfile. `npm ci` installs exactly what the lockfile says and FAILS when package.json and package-lock.json disagree, so the rename broke the install step. The lockfile is regenerated: 0 references to @quilt/ remain. 3. THE BUILD WAS BROKEN ALREADY, ON ANOTHER REPO'S SCHEDULE. tsconfig.json(16,25): error TS5108: Option 'moduleResolution=node10' has been removed. The repo pins typescript ^7.0.2, and TypeScript 7 REMOVED the node10 module resolution that "moduleResolution": "node" aliases to. So `tsc` failed, and because the test script builds first, the TESTS FAILED TOO -- with the build error as the visible symptom. The fix is the modern pair for a CommonJS package: "module": "node16", "moduleResolution": "node16" and dropping the now-meaningless "ignoreDeprecations": "6.0". This is the same shape as the k3s finding: a dependency major bumped, a config option quietly removed, and a suite that reports the SECOND symptom rather than the first. The suite was not testing the config; the config was testing the suite. Verified on this branch: npm run lint clean npm test 13 tests, 13 pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@quilt is not a scope this fleet owns -- it belongs to quiltdata, a different organisation -- so this package could never be published under that name.
"workspace:*" could not install standalone at all (EUNSUPPORTEDPROTOCOL), and it formed a dependency CYCLE with quilt-ai (ai -> evolve -> ai). Both dependencies are now real ranges against packages we own, both published, and the cycle is broken.
The lockfile is regenerated, because
npm cifails when package.json and package-lock.json disagree -- the rename broke the install step.AND THE BUILD WAS ALREADY BROKEN, ON ANOTHER REPO'S SCHEDULE:
The repo pins typescript ^7.0.2, and TypeScript 7 REMOVED the node10 module resolution that "moduleResolution": "node" aliases to.
tscfailed, and because the test script builds first, the tests failed too -- with the build error as the visible symptom.The fix is the modern pair for a CommonJS package -- "module": "node16", "moduleResolution": "node16" -- and dropping the now-meaningless "ignoreDeprecations": "6.0".
Verified on this branch:
npm run lintclean,npm test13 tests, 13 pass.