Skip to content

fix(build): backport Boost.Locale support for CMake 4.5 - #6166

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/fix-boost-locale-cmake-45
Nov 22, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/fix-boost-locale-cmake-45

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Both openSUSE Tumbleweed COPR builds stopped at CMake configuration. CMake 4.5 rejected the Boost.Locale umbrella header include/boost/locale.hpp in a source group rooted at include/boost/locale. x86_64 build log, aarch64 build log

The CPM lockfile applies the upstream Boost.Locale fix when Sunshine fetches Boost 1.92.0 on non-Windows builds with CMake 4.5 or newer. The patch removes the umbrella header from the directory-based group and keeps its existing standalone group. Upstream fix

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Reproduced the source_group failure with the locked Boost archive and CMake 4.5.0.
  • Configured Sunshine through the CPM fallback and built boost_locale on x86_64 Ubuntu WSL with CUDA disabled.
  • Checked patch selection with CMake 4.5.0, CMake 3.28.3, and the Windows condition. CMake lint and git diff --check passed.
  • Hosted COPR validation for both Tumbleweed architectures is pending.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

This pull request was generated by Codex (GPT-6.2 Sol, extra high thinking level).

Copy link
Copy Markdown
Member Author

This pull request was generated by Codex (GPT-6.2 Sol, extra high thinking level).

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 1.48kB (0.15%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 1.01MB 1.48kB (0.15%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
images/logo-*.svg -661 bytes 1.48kB -30.92%
images/logo-*.svg (New) 2.14kB 2.14kB 100.0% 🚀

@codecov

codecov Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.29%. Comparing base (ab6140e) to head (18271f8).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6166      +/-   ##
==========================================
+ Coverage   50.44%   51.29%   +0.85%     
==========================================
  Files         146      148       +2     
  Lines       32248    32591     +343     
  Branches    13465    13750     +285     
==========================================
+ Hits        16267    16718     +451     
+ Misses      14102    13810     -292     
- Partials     1879     2063     +184     
Flag Coverage Δ
Alpine-aarch64 34.73% <ø> (-0.01%) ⬇️
Alpine-x86_64 34.85% <ø> (ø)
Archlinux 35.57% <ø> (-0.02%) ⬇️
FreeBSD-amd64 35.61% <ø> (ø)
Homebrew-macos-15 49.11% <ø> (ø)
Homebrew-macos-26 49.48% <ø> (ø)
Homebrew-ubuntu-24.04 38.08% <ø> (-0.01%) ⬇️
Linux-AppImage-aarch64 40.79% <ø> (-0.01%) ⬇️
Linux-AppImage-x86_64 41.04% <ø> (ø)
PowerShell 100.00% <ø> (ø)
Web-UI 57.76% <ø> (ø)
Windows-AMD64 41.52% <ø> (?)
Windows-ARM64 35.44% <ø> (+<0.01%) ⬆️
macOS-arm64 41.87% <ø> (ø)
macOS-x86_64 40.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 58 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6140e...18271f8. Read the comment docs.

@github-actions

Copy link
Copy Markdown
Last Updated 2026-11-22 15:55:56 UTC
Source Run CI Run #6927
Commit 18271f83090816023a464c6139a4e38490bddcfa

Screenshot Comparison

PR #6166 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher merged commit 82fe0f0 into master Nov 22, 2026
83 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-boost-locale-cmake-45 branch November 22, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant