fix(app): harden preview error responses and verify sandbox messaging - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Preview resource failures previously returned raw broker and path-validation errors in the HTTP body. Return fixed messages instead, keep detailed diagnostics in the trusted Service Worker console, and return empty error bodies for HEAD requests. Existing 400, 404, and 504 status codes are preserved.
Document the necessary wildcard target origin used to transfer a MessagePort to the opaque preview iframe. Keep sandbox="allow-scripts" and the existing parent, protocol, runner, and session checks.
Related issue or specification
Addresses CodeQL alert 1 (js/stack-trace-exposure). Documents and tests the opaque-origin bootstrap reported by alert 2 (js/cross-window-information-leak).
Checks
Notes
After the updated CodeQL analysis, confirm alert 1 is fixed. Alert 2 should be dismissed only with the documented opaque-origin rationale and passing browser-test evidence. No deployment or publishing is included.