Repository navigation
Wide-event NDJSON logging (loggingsucks.com) - #14
Open
SteveParson wants to merge 2 commits into
Open
SteveParson wants to merge 2 commits into
SteveParson wants to merge 2 commits into
Conversation
Name Discord/WebSocket opcodes, DRY JSON int parsing and logging, extract heartbeat/token/dispatch helpers, and drop dead TLS state — keeping the small module layout and readability. Co-authored-by: me <me@steveparson.ca>
Apply loggingsucks.com lessons: one structured JSON event per unit of work, high-cardinality Discord IDs, business context on matches, env fields on every line, info/error only, and tail sampling via LOG_SAMPLE_RATE. Never log the bot token. Co-authored-by: me <me@steveparson.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements lessons from loggingsucks.com: stop diary-style
log_info("…")strings; emit one structured wide event per unit of work as NDJSON on stderr.This branch is stacked on the KISS cleanups from #13 (includes that commit). Merging this can supersede #13, or merge #13 first — either works.
What changed
src/log.c+ rewrittensrc/log.h:log_event/log_event_new/log_format_event/log_emitsession.start|end,gateway.hello|ready|reconnect|heartbeat|…,message.handle,tls.*request_id,channel_id,message_id,sequencematched_king, reply/reaction HTTP statuses,content_len(not message text)timestamp,service,version,pid, optionalcommitLOG_SAMPLE_RATEDISCORD_TOKEN.env.sampleExample
{"timestamp":"2026-11-03T22:50:00Z","service":"king","version":"0.1","pid":123,"event":"message.handle","outcome":"success","duration_ms":48,"request_id":"req_…","channel_id":"222","message_id":"111","matched_king":true,"reply_http_status":200,"reaction_http_status":204,"content_len":10}Verification
make docker-test # 98 passed make docker-lint