Repository navigation
Allow qualified fifth and sixth endings - #3
Merged
Merged
Conversation
…ration Add a deterministic eligibility check for settled fifth and major-sixth endings near the finite duration target, with the original tonic fallback. Preserve all random draws, planned voices, note timing, drones, tuning, synthesis and stereo behavior before the selected ending. Use replay engine 3 for the audition and retain engine 1 for saved performances. Keep the public v1.0 release line and existing release tag. Document the musical rules and replay compatibility. Validation: 60 Node checks passed (historical baseline run separately), and all 17 Chromium browser checks passed after correcting keyboard-focus setup and allowing time for repeated native exports. Prefix comparisons cover 400 dispersed seeds across three root tones and Short/Long, plus unchanged Infinite continuation.
Replace audition-branch wording with the current ending and replay behavior. No executable code changes. The musical implementation passed Node checks and native Chromium, Firefox and WebKit CI.
Stereo-Images
changed the title
Stereo-Images
marked this pull request as ready for review
October 22, 2026 00:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open currently continues finite runs until a tonic ending. Some settled passages could finish naturally on a prepared fifth or major sixth, including the recovered eleven-note contour.
This changes ending eligibility only. The check consumes no random draws and preserves melody generation, note timing, tempo, drone placement, tuning, FM voices, envelopes, room processing and stereo movement. It accepts a fifth or major sixth only after a return to a recent pitch, stable harmony, low tension and compatible remaining drones. A sixth additionally requires a stepwise excursion in a major passage. The existing tonic ending remains the fallback, and all voices retain their full decay.
The strike straddling the duration target can qualify, at most one nominal interval or six seconds early. Infinite is unchanged. New runs use musical engine 3; saved engine-1 filenames and links retain their original endings. The public release line remains v1.0, and the existing v1.0 tag is untouched. Engine 2 is reserved for the separate tempo experiment.
Validation:
Approved for adoption. README and test documentation explain the rules, compatibility and remaining limits. Eight new seeded WAVs plus the earlier favorite are saved with full replay filenames and individual standalone player pages.