Fix pirate battle UI cleanup and water tiling#1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the pirate battle royale scene and behaviors to improve UI layout on mobile/viewport safe-areas, add ocean texturing, and tighten up match UI/timer cleanup.
Changes:
- Add “safe area” aware positioning for touch controls, HUD, overlays, and countdown UI.
- Add ocean surface tiling + water texture.
- Refactor restart/cleanup logic to clear countdown timers and transient scene objects.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| Pirate-Ship-Battle-Royal-v1.0/pirate-ship-battle-royal-v1.0.stemscript | Makes several helper/boundary objects visible and adds ocean surface texture/tiling. |
| Pirate-Ship-Battle-Royal-v1.0/behaviors/ShipController.yaml | Repositions touch UI based on viewport safe area. |
| Pirate-Ship-Battle-Royal-v1.0/behaviors/PirateHUD.yaml | Repositions HUD + offscreen indicators based on viewport safe area. |
| Pirate-Ship-Battle-Royal-v1.0/behaviors/GameManager.yaml | Makes overlay/countdown safe-area aware and adds timer + transient-object cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MERGE THIS PR ONLY AFTER Stem-Studio/Engine#34
Summary
Screen.Recording.2026-06-03.at.16.57.05.mp4
Changes
_cannonballs,_cannonVFX, and_wake_skipToNextMatchOceanSurfaceto usetileAmountX=20 tileAmountY=20Validation
GameManager.yaml, extracted embedded script, and rannode --checkon the generated JStileAmountX=20 tileAmountY=20