Skip to content

Fix pirate battle UI cleanup and water tiling#1

Merged
papiguy merged 1 commit into
Stem-Studio:mainfrom
querielo:kirill/fix-pirate
Jun 3, 2026
Merged

Fix pirate battle UI cleanup and water tiling#1
papiguy merged 1 commit into
Stem-Studio:mainfrom
querielo:kirill/fix-pirate

Conversation

@querielo
Copy link
Copy Markdown
Contributor

@querielo querielo commented Jun 3, 2026

MERGE THIS PR ONLY AFTER Stem-Studio/Engine#34

Summary

  • clean up Pirate Ship Battle Royal overlay/countdown resources when the GameManager behavior is disposed
  • clear transient scene objects created during play so restart/destroy paths do not leave cannonballs, VFX, or wake meshes behind
  • set the OceanSurface texture
Screen.Recording.2026-06-03.at.16.57.05.mp4

Changes

  • added GameManager cleanup helpers for:
    • countdown timers
    • overlay/countdown DOM nodes
    • transient scene objects stored in _cannonballs, _cannonVFX, and _wake
    • scene userData hooks like _skipToNextMatch
    • cached scene/window references
  • reused the transient-object cleanup during restart so restart and dispose follow the same cleanup path
  • updated the Pirate Ship Battle Royal stemscript material for OceanSurface to use tileAmountX=20 tileAmountY=20

Validation

  • parsed GameManager.yaml, extracted embedded script, and ran node --check on the generated JS
  • verified the stemscript material line includes tileAmountX=20 tileAmountY=20

Copilot AI review requested due to automatic review settings June 3, 2026 14:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the pirate battle royale scene and behaviors to improve UI layout on mobile/viewport safe-areas, add ocean texturing, and tighten up match UI/timer cleanup.

Changes:

  • Add “safe area” aware positioning for touch controls, HUD, overlays, and countdown UI.
  • Add ocean surface tiling + water texture.
  • Refactor restart/cleanup logic to clear countdown timers and transient scene objects.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
Pirate-Ship-Battle-Royal-v1.0/pirate-ship-battle-royal-v1.0.stemscript Makes several helper/boundary objects visible and adds ocean surface texture/tiling.
Pirate-Ship-Battle-Royal-v1.0/behaviors/ShipController.yaml Repositions touch UI based on viewport safe area.
Pirate-Ship-Battle-Royal-v1.0/behaviors/PirateHUD.yaml Repositions HUD + offscreen indicators based on viewport safe area.
Pirate-Ship-Battle-Royal-v1.0/behaviors/GameManager.yaml Makes overlay/countdown safe-area aware and adds timer + transient-object cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Pirate-Ship-Battle-Royal-v1.0/behaviors/ShipController.yaml
Comment thread Pirate-Ship-Battle-Royal-v1.0/behaviors/PirateHUD.yaml
Comment thread Pirate-Ship-Battle-Royal-v1.0/behaviors/GameManager.yaml
Comment thread Pirate-Ship-Battle-Royal-v1.0/behaviors/GameManager.yaml
Comment thread Pirate-Ship-Battle-Royal-v1.0/behaviors/GameManager.yaml
@papiguy papiguy merged commit 2904943 into Stem-Studio:main Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants