chore: test cancel_match#995
Merged
famvilianity-eng merged 1 commit intoJul 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original checked state == Active then separately state != Pending. The second check already covers Active and every other non-Pending state. Collapsed into a
single check that maps the state to the correct error.
The if !already_allowed / else block called Self::append_allowed_token at the end of both branches — identical code. Lifted it out of the conditional so it runs
once unconditionally after the branching logic.
The original only checked that player2 != contract_address. player1 had the same potential problem but was never validated against it. The fix extends the guard
to cover both players in a single condition.
closes #795