Repository navigation
feat(panoptic): add AssemblyScript runtime adapter types - #14
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 983cc6482c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
| export function parsePrices(_prices: string): Array<Price> { | ||
| const payload = JSON.parse<PricePayload>(_prices); |
There was a problem hiding this comment.
When the OHLC data connector returns candle fields as strings (for example "close":"123.4"), this typed json-as parse into f32 fields no longer performs the previous Number.parseFloat(value.toString()) coercion, so existing payloads with stringified decimal prices will fail to deserialize or leave default zeros before strategy math runs.
Useful? React with 👍 / 👎.
| export class MerkleProofsByActionDto { | ||
| approveToken: string[] = []; |
There was a problem hiding this comment.
For Merkle artifacts whose proofsByAction contains any action key other than approveToken, the DTO has no place to store or serialize that proof, so merkleFindLeaf/merkleBuildManageArgs drop the required proofs before calling the host and non-approve Merkle actions cannot be built. This should be modeled as a dynamic map/record of action names to proof arrays rather than a single hard-coded field.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.