Skip to content

chore(deps+tests): combine dependabot PRs (#89,#90,#93,#94,#95,#96) + improve coverage to 99.4%#97

Merged
maximizeIT merged 12 commits into
mainfrom
chore/combine-dependabot-prs
May 13, 2026
Merged

chore(deps+tests): combine dependabot PRs (#89,#90,#93,#94,#95,#96) + improve coverage to 99.4%#97
maximizeIT merged 12 commits into
mainfrom
chore/combine-dependabot-prs

Conversation

@maximizeIT
Copy link
Copy Markdown
Contributor

@maximizeIT maximizeIT commented May 12, 2026

Combined Dependabot PRs + Test Coverage Improvements

This PR combines all 6 open dependabot pull requests and adds significant test coverage improvements.

Included Dependency PRs

Test Coverage Improvements

Metric Before After
Statements 73.3% 99.4%
Functions 30.5% 100%
Branches 70.8% 82.5%
Lines 73.3% 99.4%

Changes:

  • Installed missing eslint-plugin-n (fixes lint failure) and removed unused eslint-disable directive
  • Added tests for all 20+ SSOTokenData getter methods
  • Added _getSignedWrong sync/async/catch path tests
  • Added getSigned catch block coverage (invalid RSA key path)
  • Added SSOToken constructor appSecret edge cases (null/non-string/empty)
  • Added readKeyFile edge cases: rethrow unexpected sync errors, non-ENOENT async errors, unexpected NodeRSA async errors

Note: Only 1 line remains uncovered (SSOToken.js:105) — a defensive instanceof guard that is structurally dead code.

Co-authored-by: GitHub Copilot copilot@noreply.github.com

dependabot Bot and others added 11 commits April 1, 2026 07:41
Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.27.2 to 7.28.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.28.6/packages/babel-cli)

---
updated-dependencies:
- dependency-name: "@babel/cli"
  dependency-version: 7.28.6
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [jsonwebtoken](https://github.com/auth0/node-jsonwebtoken) from 9.0.2 to 9.0.3.
- [Changelog](https://github.com/auth0/node-jsonwebtoken/blob/master/CHANGELOG.md)
- [Commits](auth0/node-jsonwebtoken@v9.0.2...v9.0.3)

---
updated-dependencies:
- dependency-name: jsonwebtoken
  dependency-version: 9.0.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6 to 6.3.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v6...v6.3.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 10.1.0 to 10.2.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v10.1.0...v10.2.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.2.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pre-commit](https://github.com/observing/pre-commit) from 1.2.2 to 2.0.0.
- [Release notes](https://github.com/observing/pre-commit/releases)
- [Changelog](https://github.com/observing/pre-commit/blob/master/CHANGELOG.md)
- [Commits](https://github.com/observing/pre-commit/commits)

---
updated-dependencies:
- dependency-name: pre-commit
  dependency-version: 2.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@babel/plugin-transform-modules-systemjs](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-modules-systemjs) from 7.29.0 to 7.29.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.29.4/packages/babel-plugin-transform-modules-systemjs)

---
updated-dependencies:
- dependency-name: "@babel/plugin-transform-modules-systemjs"
  dependency-version: 7.29.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…s/setup-node-6.3.0' into chore/combine-dependabot-prs
…oken-9.0.3' into chore/combine-dependabot-prs
@maximizeIT maximizeIT requested a review from a team as a code owner May 12, 2026 17:48
@maximizeIT maximizeIT requested review from Ninerian and m-seidel May 12, 2026 17:48
- Install missing eslint-plugin-n (fixes lint failure)
- Remove unused eslint-disable directive in UtilFunc.test.js
- Add tests for SSOTokenData getter methods (all 20+ getters)
- Add tests for _getSignedWrong sync/async/catch paths
- Add tests for getSigned catch block (invalid RSA key)
- Add tests for SSOToken appSecret null/non-string/empty validation
- Add edge case tests for helpers.readKeyFile:
  - Sync: rethrow unexpected errors (not ENOENT/encoding too long)
  - Async: pass non-ENOENT fs errors to callback
  - Async: pass unexpected NodeRSA errors to callback

Coverage: 73.3% → 99.4% statements, 30.5% → 100% functions

Co-authored-by: GitHub Copilot <copilot@noreply.github.com>
@maximizeIT maximizeIT merged commit cdb9673 into main May 13, 2026
9 checks passed
@maximizeIT maximizeIT deleted the chore/combine-dependabot-prs branch May 13, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants