fix(results-panel): replace Recharts bars with CSS bars so full label text is always visible#201
Merged
Merged
Conversation
… text is always visible Recharts horizontal bar chart clips long Y-axis labels at the container edge regardless of the computed width — sentence-length options like 'Agent bought and paid on its own, running in about an hour' were showing as 'gent bought and paid on its...' with the leading characters cut off. Replace the Recharts BarChart/ResponsiveContainer stack with a plain CSS implementation: full label text on one line, 2px bar scaled to max value, count on the right. No truncation, no Canvas 0-width bug, no Recharts import in this component.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Recharts horizontal bar chart clips long Y-axis labels at the container edge regardless of the computed
widthprop. Sentence-length options like"Agent bought and paid on its own, running in about an hour"were rendering as"gent bought and paid on its…"— the leading characters chopped off by Recharts' internal canvas clipping.The dynamic
yAxisWidth/tickFormatterapproach from #199 still couldn't fix this because Recharts clips the label text at the pixel boundary of the axis, not at the character boundary of the formatter.Fix
Replace the entire
BarChart/ResponsiveContainer/YAxisstack with a plain CSS implementation:bg-displaybar scaled proportionally to the max value in that chartTest plan
cd client && npm run build✓