Conversation
- biggestBlocker: tally() not textSamples() (it is a single-select field, not free text) — removes duplicates and enables a proper bar chart - buildFeedbackInsights: pattern-match option strings instead of hardcoded short keys; actual stored values are 'Yes, already planning to'/'Maybe', not 'yes'/'maybe'; same fix for deadlineStatus (full sentence options, not 'comfortable'/'tight') - FeedbackChart: dynamic YAxis width computed from longest label (max 160px) + tickFormatter truncation so long option strings are readable - Layout: 6-chart grid (adds surfacesPrimary + biggestBlocker); replaces the old 'BIGGEST BLOCKERS' text list; adds 'WHAT COULDN'T BITREFILL HANDLE' for couldntHandle free-text responses - Refresh button: increments refreshTick dep so leaderboard/stats/feedback can be reloaded after score re-saves without a full page refresh - Mock data: updated to use real Bitrefill option strings so dev:harness exercises the same code paths as production
fix(results-panel): correct feedback charts, insights, and add refresh
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes five bugs in the completed-program results panel found in production after the initial ship.
YAxiswidth (max 160px) computed from longest label +tickFormattertruncation; full text on hover via existing<Tooltip>biggestBlockerchanged fromtextSamples()totally()server-side; now a proper bar chart, not a text list with repeated stringsbuildFeedbackInsightsnow uses/^yes/i//^maybe/iregex matching; actual stored values are"Yes, already planning to"/"Maybe", not"yes"/"maybe"; same fix fordeadlineStatus(full sentence options, not"comfortable"/"tight")couldntHandlefree-text never shown — added·WHAT BITREFILL COULDN'T HANDLE (OPEN TEXT)section↺ REFRESHbutton in section header re-triggers the data fetch without a full page reloaddev:harnesscatches future key-mismatch bugsTest plan
cd client && npm run build✓cd server && npm test✓ (439/439)Stadium tester — 5/5 PASS
Console errors during run: 0
Closes post-ship bugs from #195 / #197.