Skip to content

Release: live judging results, no double-counting, claim-after-submit, inline scoring#190

Merged
sacha-l merged 6 commits into
mainfrom
develop
Jun 17, 2026
Merged

Release: live judging results, no double-counting, claim-after-submit, inline scoring#190
sacha-l merged 6 commits into
mainfrom
develop

Conversation

@sacha-l

@sacha-l sacha-l commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Promotes developmain (prod deploy). Ships the judging improvements from #189.

Included

  • Live results — no more "RESULTS LOCKED"; the standings table is always visible with a ·LIVE coverage banner. PUBLISH stays gated until every submission is scored.
  • Only email-judge votes count — wallet/admin sessions are "preview" and never count, so an admin who is also an email judge isn't double-counted.
  • Claim + score more batches after submitting — the ballot-submit no longer locks you out of claiming more.
  • VIDEO + GitHub links on every results row.
  • Inline scoring from RESULTS — expand a project to edit + re-save your own score; standings refresh live.

Safety

  • No migration (read-path / UI only; no schema change).
  • 439 server tests pass; client build + lint clean.

sacha-l added 6 commits June 17, 2026 19:19
… scores

The RESULTS tab no longer hides the standings behind a lock. The leaderboard
now counts every saved score (not only finalized ballots), so it's live as
judges score and an admin's own scores show up immediately. 'complete' (every
submission scored) is informational and gates only PUBLISH; a LIVE banner shows
coverage. Admins add scores via the SCORE tab as before; they now appear here.

438 server tests pass (leaderboard + sim journey updated for live behavior);
client build + lint clean.
…g their ballot

The ballot-submit lock blocked claiming new batches (409), so a judge who
submitted one batch couldn't go through the rest. Since saved scores now count,
remove that lock: claiming stays open after submit, and the batch overview is
shown even when 'submitted'. Scores from later batches count on save.
…judges

My earlier 'count all saved scores' change started counting wallet/admin
sessions as a separate judge, so someone who is both an admin wallet and an
email judge (e.g. sacha@) was double-counted in the leaderboard and breakdown.
Count only email-judge scores (judgeEmail contains '@'); wallet sessions remain
admin previews that never count. Applies to the leaderboard + the live overview.
The RESULTS leaderboard rows showed only title + scores. Add inline VIDEO
(opens the review modal) and GIT links per row so they're accessible without
expanding. Links stop row-click propagation so they don't toggle the breakdown.
…e-save)

Expand a results row to get your own score inputs (pre-filled from your saved
score) and a SAVE/RE-SAVE button, so a judge can score or revise a project
straight from the final results without going back to the batch flow. Adds
myScore per leaderboard row (the viewing judge's own score).
feat(judging): live results (remove RESULTS LOCKED)
@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
stadium Ready Ready Preview, Comment Jun 17, 2026 5:43pm

@sacha-l sacha-l merged commit 87d6d92 into main Jun 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant