Conversation
… status update 1) RLS: the Supabase Data API exposed every public table to the anon key (shipped in the client bundle) for read AND write — verified anon could SELECT/DELETE/UPDATE projects, program_admins, multisig_*. Enable RLS (deny-all) on all public tables; server uses service_role (BYPASSRLS) and the client only uses Supabase auth, so zero functional impact. Already applied to prod; committing so repo history matches. 2) IDOR: updateApplicationStatus updated by applicationId without verifying it belongs to the program in the slug, letting a program-A admin mutate program-B applications. Now fetch + assert programId match before any write. 429 server tests pass.
security: enable RLS on public tables + fix cross-program IDOR
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
develop→main(prod deploy). Carries only the security fixes merged since the last release (#181).Included (#182)
updateApplicationStatus— a program-A admin could mutate program-B applications; now scoped + tested.Verification
429 server tests pass; client build + lint clean. RLS already verified closed on prod (anon →
[]).Not in this deploy (runtime, separate)