Discover agent cluster names from referenced Secrets - #130
Merged
Merged
Conversation
Keep ConfigMap discovery first, then follow cluster-name secretKeyRef entries on agent deployments using the current Rancher user's permissions. Read only named Secrets and preserve the display-name fallback when access or data is unavailable. Cover discovery precedence, missing and denied resources, OTel references, and health-query/component-link identity. Document the Secret access boundary and add a patch changeset. Tracking: StackVista/helm-charts-internal#210
🦋 Changeset detectedLatest commit: d502637 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LouisLotter
approved these changes
Sep 25, 2026
LouisLotter
reviewed
Sep 25, 2026
fvlankvelt
reviewed
Sep 25, 2026
LouisLotter
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep ConfigMap discovery first, then read the cluster-name Secret referenced by an agent Deployment. This fixes health queries and component links when Secret-only configuration uses a different name from Rancher.
Secret reads require the current user’s permission; no RBAC expansion or Secret listing. Includes a patch changeset and fallback/error tests.
Tracking: https://github.com/StackVista/helm-charts-internal/issues/210
Validation: 33 tests, typecheck, lint (warnings only), Prettier, Changesets check and extension build.