Skip to content

ConnectionAttemptCompleted: take the sequence number and timestamp together #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 1 commit into from
Oct 12, 2026
Merged

ConnectionAttemptCompleted: take the sequence number and timestamp together #3270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/StackExchange.Redis/ConnectionMultiplexer.Events.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,17 @@ internal void OnConnectionAttemptCompleted(
var handler = RawConfig.ConnectionAttemptCompletedHandler;
if (handler != null)
{
var sequenceNumber = Interlocked.Increment(ref _connectionAttemptSequence);
// the sequence and the timestamp are taken together, so that they agree on the order: taken apart, two
// attempts completing at once (the interactive and subscription connections failing together) could each
// take one first and the other second, and a later sequence number would carry an earlier time
long sequenceNumber;
DateTime completedTimeUtc;
lock (_connectionAttemptSequenceLock)
{
sequenceNumber = ++_connectionAttemptSequence;
completedTimeUtc = DateTime.UtcNow;
}

CompleteAsWorker(new ConnectionAttemptCompletedEventArgs(
handler,
this,
Expand All @@ -39,12 +49,13 @@ internal void OnConnectionAttemptCompleted(
tlsHostName,
serverCertificateCheck,
sequenceNumber,
DateTime.UtcNow,
completedTimeUtc,
physicalName));
}
}

private long _connectionAttemptSequence;
private readonly object _connectionAttemptSequenceLock = new();

/// <summary>
/// Raised whenever a physical connection fails.
Expand Down
Loading