Skip to content

Return 0 from SortedSetRemove(Async) for an empty member array #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 1 commit into from
Aug 25, 2026
Merged

Return 0 from SortedSetRemove(Async) for an empty member array #3192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/StackExchange.Redis/RedisDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2718,6 +2718,8 @@ public bool SortedSetRemove(RedisKey key, RedisValue member, CommandFlags flags

public long SortedSetRemove(RedisKey key, RedisValue[] members, CommandFlags flags = CommandFlags.None)
{
if (members == null) throw new ArgumentNullException(nameof(members));
if (members.Length == 0) return 0;
var msg = Message.Create(Database, flags, RedisCommand.ZREM, key, members);
return ExecuteSync(msg, ResultProcessor.Int64);
}
Expand All @@ -2730,6 +2732,8 @@ public Task<bool> SortedSetRemoveAsync(RedisKey key, RedisValue member, CommandF

public Task<long> SortedSetRemoveAsync(RedisKey key, RedisValue[] members, CommandFlags flags = CommandFlags.None)
{
if (members == null) throw new ArgumentNullException(nameof(members));
if (members.Length == 0) return CompletedTask<long>.FromResult(0, asyncState);
var msg = Message.Create(Database, flags, RedisCommand.ZREM, key, members);
return ExecuteAsync(msg, ResultProcessor.Int64);
}
Expand Down
22 changes: 22 additions & 0 deletions tests/StackExchange.Redis.Tests/SortedSetTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1508,4 +1508,26 @@ public async Task SortedSetUpdate()
Assert.True(await db.SortedSetUpdateAsync(key, member, 1));
Assert.Equal(1, await db.SortedSetUpdateAsync(key, values));
}

[Fact]
public async Task SortedSetRemoveArgTests()
{
await using var conn = Create();

var db = conn.GetDatabase();
var key = Me();

RedisValue[]? members = null;
var ex = Assert.Throws<ArgumentNullException>(() => db.SortedSetRemove(key, members!));
Assert.Equal("members", ex.ParamName);
ex = await Assert.ThrowsAsync<ArgumentNullException>(async () => await db.SortedSetRemoveAsync(key, members!).ForAwait()).ForAwait();
Assert.Equal("members", ex.ParamName);

members = [];
Assert.Equal(0, db.SortedSetRemove(key, members));

var pending = db.SortedSetRemoveAsync(key, members);
Assert.True(pending.IsCompleted); // sync; never reaches the server
Assert.Equal(0, await pending.ForAwait());
}
}
Loading